<p><b>@freimair</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2469#discussion_r263334334">common/src/main/java/bisq/common/app/Capabilities.java</a>:</p>
<pre style='color:#555'>> -    // Sequence in the enum must not be changed (append only).
-    public enum Capability {
-        TRADE_STATISTICS,
-        TRADE_STATISTICS_2,
-        ACCOUNT_AGE_WITNESS,
-        SEED_NODE,
-        DAO_FULL_NODE,
-        PROPOSAL,
-        BLIND_VOTE,
-        ACK_MSG,
-        BSQ_BLOCK
+
+    /**
+     * The global set of capabilities, i.e. the capabilities if the local app.
+     */
+    public static final Capabilities app = new Capabilities();
</pre>
<blockquote>
<p>I would prefer a more descriptive name here. When I read Capabilities.app it was not very clear what it means.</p>
</blockquote>
<p>make a suggestion</p>
<blockquote>
<p>Also does not need to be static?</p>
</blockquote>
<p>yes, as it hold the capabilities of the running Bisq itself and is used in multiple places all over the code.</p>
<blockquote>
<p>Should the class extend HashSet instead of using the field capabilities - as that is basically what it holds?</p>
</blockquote>
<p>see below</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2469#discussion_r263334334">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtga9p9xUJISthL3MAL7oqIPkp8zEks5vUPI4gaJpZM4bRz-x">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtkTmL_k3yfiEvGbQ7T2blMA7ks5lks5vUPI4gaJpZM4bRz-x.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@freimair commented on #2469"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2469#discussion_r263334334"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2469#discussion_r263334334",
"url": "https://github.com/bisq-network/bisq/pull/2469#discussion_r263334334",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>