<p><b>@ben-kaufman</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2515#discussion_r263677260">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java</a>:</p>
<pre style='color:#555'>>              });
+            cycleJson.addProperty("numberOfProposals", proposalsArray.size());
</pre>
<p>This seems to be a duplicate of <code>proposalsCount</code>. Please remove one of them.<br>
If you keep this one, I suggest to also change the name of <code>votesCount</code> to <code>numberOfVotes</code> and make it an int to keep consistency.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2515#pullrequestreview-212154729">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkqGSFV0XF-a4I2DBwNtGMzzD--qks5vUgP5gaJpZM4bkSFz">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZth2-9A8KqARJiAUEdJM-6T8dn_F3ks5vUgP5gaJpZM4bkSFz.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ben-kaufman commented on #2515"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2515#pullrequestreview-212154729"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2515#pullrequestreview-212154729",
"url": "https://github.com/bisq-network/bisq/pull/2515#pullrequestreview-212154729",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>