<p><b>@ben-kaufman</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2526#discussion_r264327954">core/src/main/java/bisq/core/dao/DaoFacade.java</a>:</p>
<pre style='color:#555'>> @@ -530,8 +531,8 @@ public long getTotalAmountOfConfiscatedTxOutputs() {
 
 
     public List<Bond> getAllBonds() {
-        List<Bond> bonds = bondedReputationRepository.getActiveBonds();
-        bonds.addAll(bondedRolesRepository.getActiveBonds());
+        List<Bond> bonds = new ArrayList<>(bondedReputationRepository.getBonds());
</pre>
<p>Yes, but it is needed there to display also old items correctly.<br>
For the <code>setItems</code> I'm not sure as you do want to display the link if you choose to display the proposal, but there is no reason to have such an active proposal in the first place.</p>
<p>Anyway, in <code>getBondByLockupTxId</code> we want also non-active bonds so it is possible to see past proposals correctly.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2526#discussion_r264327954">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvdkwoOAVmc3fNGWfV68TfLKBI7Gks5vVomUgaJpZM4boAn0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnQnNXL2bYLLoiawgfjCR_UdueAiks5vVomUgaJpZM4boAn0.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ben-kaufman commented on #2526"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2526#discussion_r264327954"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2526#discussion_r264327954",
"url": "https://github.com/bisq-network/bisq/pull/2526#discussion_r264327954",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>