<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2541#discussion_r266176604">desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java</a>:</p>
<pre style='color:#555'>> @@ -147,13 +162,18 @@ public void unLock(String lockupTxId, Consumer<String> resultHandler) {
 
             try {
                 if (!DevEnv.isDevMode()) {
+                    Tuple2<Coin, Integer> miningFeeAndTxSize = daoFacade.getMiningFeeAndTxSize(unlockAmount);
+                    Coin miningFee = miningFeeAndTxSize.first;
</pre>
<p>Unfortunately daoFacade.getMiningFeeAndTxSize is not correctly named. It is only valid for the blind vote tx (I will rename the method in another commit). We need to use the correct tx which will be created at the unlock tx (without triggering any side effects as the user can cancel).</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2541#discussion_r266176638">desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java</a>:</p>
<pre style='color:#555'>> @@ -101,18 +105,29 @@ private void lockupBond(byte[] hash, Coin lockupAmount, int lockupTime, LockupRe
                             Consumer<String> resultHandler) {
         if (GUIUtil.isReadyForTxBroadcast(p2PService, walletsSetup)) {
             if (!DevEnv.isDevMode()) {
-                BSFormatter formatter = new BSFormatter();
-                String duration = formatter.formatDurationAsWords(lockupTime * 10 * 60 * 1000L, false, false);
-                new Popup<>().headLine(Res.get("dao.bond.reputation.lockup.headline"))
-                        .confirmation(Res.get("dao.bond.reputation.lockup.details",
-                                bsqFormatter.formatCoinWithCode(lockupAmount),
-                                lockupTime,
-                                duration
-                        ))
-                        .actionButtonText(Res.get("shared.yes"))
-                        .onAction(() -> publishLockupTx(hash, lockupAmount, lockupTime, lockupReason, resultHandler))
-                        .closeButtonText(Res.get("shared.cancel"))
-                        .show();
+                try {
+                    Tuple2<Coin, Integer> miningFeeAndTxSize = daoFacade.getMiningFeeAndTxSize(lockupAmount);
+                    Coin miningFee = miningFeeAndTxSize.first;
</pre>
<p>Unfortunately daoFacade.getMiningFeeAndTxSize is not correctly named. It is only valid for the blind vote tx (I will rename the method in another commit). We need to use the correct tx which will be created at the lockup (without triggering any side effects as the user can cancel).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2541#pullrequestreview-215286133">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtnr4M6tKDAnPoXqdhSIVMnnvzNL3ks5vXDECgaJpZM4b3B88">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtsL6SOCQOcK0r-ZtXh7Awv-z_FENks5vXDECgaJpZM4b3B88.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #2541"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2541#pullrequestreview-215286133"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2541#pullrequestreview-215286133",
"url": "https://github.com/bisq-network/bisq/pull/2541#pullrequestreview-215286133",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>