<p><b>@sqrrm</b> commented on this pull request.</p>

<p>My comment on throwing an exception only happened midway through these commits. I still think it can happen but couldn't recreate it.</p>
<p>Everything looks good while running on the current tip. I think it's basically good to go.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2532#discussion_r265569730">core/src/main/java/bisq/core/dao/state/monitoring/DaoStateMonitoringService.java</a>:</p>
<pre style='color:#555'>> +
+    public void createHashFromBlock(Block block) {
+        updateHashChain(block);
+    }
+
+    public void requestHashesFromGenesisBlockHeight(String peersAddress) {
+        daoStateNetworkService.requestHashes(genesisTxInfo.getGenesisBlockHeight(), peersAddress);
+    }
+
+    public void applySnapshot(LinkedList<DaoStateHash> persistedDaoStateHashChain) {
+        // We could got a reset from a reorg, so we clear all and start over from the genesis block.
+        daoStateHashChain.clear();
+        daoStateBlockchain.clear();
+        daoStateNetworkService.reset();
+
+        log.info("Apply snapshot: Last daoStateHash={}", persistedDaoStateHashChain.getLast());
</pre>
<p>This throws an exception for an empty persistedDaoStateHashChain.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2532#pullrequestreview-214509889">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtlsZqGUy9dFCLfu6iAXBotarbvk3ks5vXSXggaJpZM4bpx1r">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvOEavnM4dlDiUD1y6kBEDCj3YR6ks5vXSXggaJpZM4bpx1r.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm commented on #2532"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2532#pullrequestreview-214509889"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2532#pullrequestreview-214509889",
"url": "https://github.com/bisq-network/bisq/pull/2532#pullrequestreview-214509889",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>