<p><b>@freimair</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2552#discussion_r266586536">p2p/src/main/java/bisq/network/p2p/peers/PeerManager.java</a>:</p>
<pre style='color:#555'>> @@ -176,7 +176,7 @@ public void readPersisted() {
         PeerList persistedPeerList = storage.initAndGetPersistedWithFileName("PeerList", 1000);
         if (persistedPeerList != null) {
             long peersWithNoCapabilitiesSet = persistedPeerList.getList().stream()
-                    .filter(e -> e.getCapabilities().hasCapabilities())
+                    .filter(e -> e.getCapabilities().isEmpty())
</pre>
<p>asdf</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2552#discussion_r266588402">p2p/src/main/java/bisq/network/p2p/peers/PeerManager.java</a>:</p>
<pre style='color:#555'>> @@ -176,7 +176,7 @@ public void readPersisted() {
         PeerList persistedPeerList = storage.initAndGetPersistedWithFileName("PeerList", 1000);
         if (persistedPeerList != null) {
             long peersWithNoCapabilitiesSet = persistedPeerList.getList().stream()
-                    .filter(e -> e.getCapabilities().hasCapabilities())
+                    .filter(e -> e.getCapabilities().isEmpty())
</pre>
<p>This is a bug which has been introduced with the previous refactoring.</p>
<p>The goal is a list of peers which have no capabilities assigned. This list is counted and then reported either as <code>log.warn</code> (in case more than hardcoded 100 persisted peers have no capabilities assigned) or a <code>log.info</code>. Currently, however, the code counts peers which have capabilities (<code>hasCapabilities</code>) assigned. So no breaking bug that shows itself easily.</p>
<p>This change restores the functionality as intended originally by leaving only peers with empty capability sets in the list.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2552#discussion_r266586536">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtipAnQrx_VYXU4oTq4a8RtCeHiDLks5vX944gaJpZM4b5n-2">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtl12xYWTJ2NViamGskTxuKwj_M3gks5vX944gaJpZM4b5n-2.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@freimair commented on #2552"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2552#discussion_r266586536"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2552#discussion_r266586536",
"url": "https://github.com/bisq-network/bisq/pull/2552#discussion_r266586536",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>