<p>It turned out that changing any field in the Param can break consensus.</p>
<ul>
<li>Name of the params must not change as that is used for serialisation in Protobuffer. The data fields are not part of</li>
<li>the PB serialisation so changes for those would not change the hash for the dao state hash chain.</li>
<li>Though changing the values might break consensus as the validations might return a different result (e.g. a param</li>
<li>change proposal was accepted with older min/max values but then after a change it is not valid anymore and</li>
<li>might break the consequences of that change. So in fact we MUST not change anything here, only way is to add new</li>
<li>entries and don't use the deprecated enum in future releases anymore.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/2555#issuecomment-474638676">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtppFDZIpzoRZQOde12eQHFeSeuOfks5vYYOSgaJpZM4b6H5G">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtpKomYBvswYcdulOer6KLAUfY_z-ks5vYYOSgaJpZM4b6H5G.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2555: It turned out that changing any field in the Param can break consensus.\r\n\r\n * Name of the params must not change as that is used for serialisation in Protobuffer. The data fields are not part of\r\n * the PB serialisation so changes for those would not change the hash for the dao state hash chain.\r\n * Though changing the values might break consensus as the validations might return a different result (e.g. a param\r\n * change proposal was accepted with older min/max values but then after a change it is not valid anymore and\r\n * might break the consequences of that change. So in fact we MUST not change anything here, only way is to add new\r\n * entries and don't use the deprecated enum in future releases anymore."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/2555#issuecomment-474638676"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/2555#issuecomment-474638676",
"url": "https://github.com/bisq-network/bisq/issues/2555#issuecomment-474638676",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>