<p><b>@devinbileck</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2556#discussion_r267216452">core/src/main/java/bisq/core/dao/monitoring/ProposalStateMonitoringService.java</a>:</p>
<pre style='color:#555'>>          if (proposalStateBlockChain.isEmpty() && blockHeight > genesisBlockHeight) {
             // Takes about 150 ms for dao testnet data
             long ts = System.currentTimeMillis();
             for (int i = genesisBlockHeight; i < blockHeight; i++) {
-                maybeUpdateHashChain(i);
+                hashChainUpdated = hashChainUpdated || maybeUpdateHashChain(i);
</pre>
<p>Does this not have the unintended consequence of only updating the hashchain for the first cycle? Since once maybeUpdateHashChain returns true (first block of blind vote phase), this statement will short-circuit and not call maybeUpdateHashChain for any other blocks?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2556#pullrequestreview-216565382">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmyM3-OPSkTxNqI59NF03t8xC7L5ks5vYeitgaJpZM4b6eYt">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtqZ8J15SqBuJCKabhRRUBY2wuppUks5vYeitgaJpZM4b6eYt.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@devinbileck commented on #2556"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2556#pullrequestreview-216565382"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2556#pullrequestreview-216565382",
"url": "https://github.com/bisq-network/bisq/pull/2556#pullrequestreview-216565382",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>