<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2556#discussion_r267629835">core/src/main/java/bisq/core/dao/governance/proposal/param/ChangeParamValidator.java</a>:</p>
<pre style='color:#555'>> +     *
+     * @param currentValue      Current value
+     * @param newValue          New value
+     * @param min               Decrease of param value limited to current value / maxDecrease. If 0 we don't apply the check and any change is possible
+     * @param max               Increase of param value limited to current value * maxIncrease. If 0 we don't apply the check and any change is possible
+     * @return Validation result
+     */
+    @VisibleForTesting
+    static Result getChangeValidationResult(double currentValue, double newValue, double min, double max) {
+        checkArgument(min >= 0, "Min must be >= 0");
+        checkArgument(max >= 0, "Max must be >= 0");
+        if (currentValue == newValue)
+            return Result.SAME;
+
+        if (max == 0)
+            return Result.OK;
</pre>
<p>Yes that is not correct. Was a bit too lazy... Basically there is no use case for setting one to 0 and the other not. But should handle it correclty... The whole validation code could need more love...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2556#discussion_r267629835">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmjTM4Qbcus3gi6q1kAyFfE05Qelks5vYxsQgaJpZM4b6eYt">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZts5TBiB9sbEqllUGXcIQiM3sVKbGks5vYxsQgaJpZM4b6eYt.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #2556"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2556#discussion_r267629835"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2556#discussion_r267629835",
"url": "https://github.com/bisq-network/bisq/pull/2556#discussion_r267629835",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>