<p>Overview</p>
<ul>
<li>Changes done on bisq's bitcoinj just support onion v2 addresses.</li>
<li>Most of the code needed to support tor/onion services is in <a href="https://github.com/bisq-network/bisq">https://github.com/bisq-network/bisq</a> (out of scope of this audit)</li>
<li>Upstream tor support in bitcoinj was removed because it was not well maintained and caused problems and there were no volunteers to maintain it (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="189213940" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1314" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1314/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1314">bitcoinj#1314</a>)</li>
<li>Tor support could be re-enabled upstream by contributing changes done on bisq's bitcoinj and on <a href="https://github.com/bisq-network/bisq">https://github.com/bisq-network/bisq</a></li>
<li>Tor support upstream could provide
<ul>
<li>Connect to peers running behind an onion address</li>
<li>Resolve DNS over tor</li>
<li>Connect via tor to clearnet peers</li>
<li>A mechanism to start a local tor client (orchid or another tor client)</li>
</ul>
</li>
</ul>
<p>Commit review</p>
<ul>
<li><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bitcoinj/commit/011fe40d971631106980c28df3ed8a51e7e875f6/hovercard" href="https://github.com/bisq-network/bitcoinj/commit/011fe40d971631106980c28df3ed8a51e7e875f6"><tt>011fe40</tt></a>
<ul>
<li>No changes suggested.</li>
<li>Created PR upstream <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="423342334" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1741" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1741/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1741">bitcoinj#1741</a></li>
</ul>
</li>
<li><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bitcoinj/commit/834f57a1c17758f46bddb8335f009f010c95ba41/hovercard" href="https://github.com/bisq-network/bitcoinj/commit/834f57a1c17758f46bddb8335f009f010c95ba41"><tt>834f57a</tt></a>
<ul>
<li>No changes suggested.</li>
<li>Created PR upstream <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="423450505" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1742" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1742/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1742">bitcoinj#1742</a></li>
</ul>
</li>
<li><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bitcoinj/commit/0988148bbb05e1d11e718aa421855ee7629d0778/hovercard" href="https://github.com/bisq-network/bitcoinj/commit/0988148bbb05e1d11e718aa421855ee7629d0778"><tt>0988148</tt></a>
<ul>
<li>No changes suggested.</li>
</ul>
</li>
<li><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bitcoinj/commit/9f09a8953469bfdbf809384f1c91dab953fe284d/hovercard" href="https://github.com/bisq-network/bitcoinj/commit/9f09a8953469bfdbf809384f1c91dab953fe284d"><tt>9f09a89</tt></a>
<ul>
<li>See <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="424328563" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/24" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/24/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/24">#24</a></li>
</ul>
</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bitcoinj/issues/25">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtjbGpsJK8jxn3UqGFF3Q2ZYt0lpEks5vZRi1gaJpZM4cEHRa">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtkDeFtYq7uSh8kIX0LrZFWzxqrONks5vZRi1gaJpZM4cEHRa.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bitcoinj","title":"bisq-network/bitcoinj","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bitcoinj"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Bisq’s bitcoinj tor/onion changes audit (#25)"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bitcoinj/issues/25"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bitcoinj/issues/25",
"url": "https://github.com/bisq-network/bitcoinj/issues/25",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>