<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=23560607" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=603793" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/devinbileck">@devinbileck</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a><br>
I know that is a monster PR and hard to review.<br>
Still would love to get it soon merged so we have some time for dev testing before next release.<br>
I will continue testing the next hours, but tested already quite a lot. If nobody can review in the next hour I will consider to merge despite an ACK. If any NACK arrives I will not merge of course....</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2556#issuecomment-475667122">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqGfbB1pqIudJII34281h_qYmOsxks5vZPfvgaJpZM4b6eYt">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtg12_O80XIvNcTknZG62s1zX5Jigks5vZPfvgaJpZM4b6eYt.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2556: @sqrrm @devinbileck @ripcurlx\r\nI know that is a monster PR and hard to review.\r\nStill would love to get it soon merged so we have some time for dev testing before next release.\r\nI will continue testing the next hours, but tested already quite a lot. If nobody can review in the next hour I will consider to merge despite an ACK. If any NACK arrives I will not merge of course...."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2556#issuecomment-475667122"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2556#issuecomment-475667122",
"url": "https://github.com/bisq-network/bisq/pull/2556#issuecomment-475667122",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>