<p>Issue: When attempting to create an offer without a trading account for<br>
the selected currency, a prompt is shown asking the user whether to still<br>
create an offer or to create a new account. But this prompt is missing a<br>
cancel/close button in case you don't want to do either action. And<br>
pressing Esc on the keyboard proceeds to create the account.<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/603793/55036019-98671980-4fd6-11e9-8337-450e0a0e411f.png"><img src="https://user-images.githubusercontent.com/603793/55036019-98671980-4fd6-11e9-8337-450e0a0e411f.png" alt="image" style="max-width:100%;"></a></p>
<p>Cause: The close button on the prompt was renamed and being used to<br>
create a new account.</p>
<p>Fix: Use the close button as a close button and add a secondary action<br>
button to create a new account. The popup width was increased to<br>
accommodate the long button text without being truncated.<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/603793/55036026-9d2bcd80-4fd6-11e9-815f-f75f25f404b0.png"><img src="https://user-images.githubusercontent.com/603793/55036026-9d2bcd80-4fd6-11e9-815f-f75f25f404b0.png" alt="image" style="max-width:100%;"></a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2590'>https://github.com/bisq-network/bisq/pull/2590</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Show close button when creating offer without required account</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2590/files#diff-0">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java</a>
    (5)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2590.patch'>https://github.com/bisq-network/bisq/pull/2590.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2590.diff'>https://github.com/bisq-network/bisq/pull/2590.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2590">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtonnWtC_OPc0KNqVhnfxIlLxNOy7ks5vapaKgaJpZM4cMhqb">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtlhy2B5rvCZ1ftY9ERV0hmlwxoPHks5vapaKgaJpZM4cMhqb.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Show close button when creating offer without required account (#2590)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2590"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2590",
"url": "https://github.com/bisq-network/bisq/pull/2590",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>