<h2>2019.03 report</h2>
<p>Audits:</p>
<ul>
<li>Connection handling changes audit
<ul>
<li>in progress</li>
</ul>
</li>
<li>"addr" message support audit
<ul>
<li>Audit report: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="425644338" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/28" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bitcoinj/issues/28/hovercard" href="https://github.com/bisq-network/bitcoinj/issues/28">bisq-network/bitcoinj#28</a></li>
<li>Bugfix: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="425972821" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2591" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2591/hovercard" href="https://github.com/bisq-network/bisq/pull/2591">bisq-network/bisq#2591</a></li>
<li>Add link to this report on the source code: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="425975539" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/29" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/29/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/29">bisq-network/bitcoinj#29</a></li>
</ul>
</li>
<li>fee calculation changes audit
<ul>
<li>Commit to audit: <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/oscarguindzberg/bitcoinj/commit/7dd1bfd9c3028266a5f8d1954cbf259ee3907e9b/hovercard" href="https://github.com/oscarguindzberg/bitcoinj/commit/7dd1bfd9c3028266a5f8d1954cbf259ee3907e9b">oscarguindzberg/bitcoinj@<tt>7dd1bfd</tt></a></li>
<li>Fix: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="425111482" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/27" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/27/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/27">bisq-network/bitcoinj#27</a></li>
</ul>
</li>
<li>Tor support audit
<ul>
<li>Audit report: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="424331257" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/25" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bitcoinj/issues/25/hovercard" href="https://github.com/bisq-network/bitcoinj/issues/25">bisq-network/bitcoinj#25</a></li>
<li>Improvements: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="424328563" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/24" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/24/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/24">bisq-network/bitcoinj#24</a></li>
<li>Created a couple of PR on bitcoinj upstream
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="423342334" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1741" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1741/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1741">bitcoinj/bitcoinj#1741</a></li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="423450505" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1742" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1742/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1742">bitcoinj/bitcoinj#1742</a></li>
</ul>
</li>
</ul>
</li>
</ul>
<p>Other improvements:</p>
<ul>
<li>Compile bitcoinj with openjdk10
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="422869079" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/23" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/23/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/23">bisq-network/bitcoinj#23</a></li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="422895623" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2564" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2564/hovercard" href="https://github.com/bisq-network/bisq/pull/2564">bisq-network/bisq#2564</a></li>
</ul>
</li>
<li>Move clear blockstore feature to bitcoinj
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="422867951" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/22" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/22/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/22">bisq-network/bitcoinj#22</a></li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="422889119" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2563" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2563/hovercard" href="https://github.com/bisq-network/bisq/pull/2563">bisq-network/bisq#2563</a></li>
</ul>
</li>
<li>Update testnet dns seeds <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="424936925" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/26" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/26/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/26">bisq-network/bitcoinj#26</a></li>
<li>Restore from seed
<ul>
<li>Retest bitcoinj upstream bug <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="411654460" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1704" data-hovercard-type="issue" data-hovercard-url="/bitcoinj/bitcoinj/issues/1704/hovercard" href="https://github.com/bitcoinj/bitcoinj/issues/1704">bitcoinj/bitcoinj#1704</a> because I was told it was solved. Report what is working and what is not. I had to update to java 11 because the wallet template bitcoinj subproject now requires that. It's important for us that have a benchmark wallet to know how restore from seed should work on bitcoinj.</li>
<li>Complete “Restore from seed using blockstore.clear() fix” upstream PR <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410935249" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1702" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1702/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1702">bitcoinj/bitcoinj#1702</a> (not merged yet)</li>
</ul>
</li>
</ul>
<p>Research/exploratory tasks:</p>
<ul>
<li>Signet network research
<ul>
<li>It is a “stable testnet” with proof of authority.</li>
<li>See email thread on bitcoin core mailing list <a href="https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016734.html" rel="nofollow">https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016734.html</a></li>
<li>Started bitcoinj signet implementation <a href="https://github.com/oscarguindzberg/bitcoinj/tree/signet">https://github.com/oscarguindzberg/bitcoinj/tree/signet</a></li>
</ul>
</li>
<li>Rebroadcasting research
<ul>
<li>See bitcoinj mailing list <a href="https://groups.google.com/forum/#!topic/bitcoinj/lkK9N3NhoPY" rel="nofollow">https://groups.google.com/forum/#!topic/bitcoinj/lkK9N3NhoPY</a></li>
<li>See “reject” msg removal in bitcoin core mailing list <a href="https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016701.html" rel="nofollow">https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016701.html</a></li>
</ul>
</li>
</ul>
<p>/cc <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="427007611" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/compensation/issues/250" data-hovercard-type="issue" data-hovercard-url="/bisq-network/compensation/issues/250/hovercard" href="https://github.com/bisq-network/compensation/issues/250">bisq-network/compensation#250</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/roles/issues/8#issuecomment-478048635">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqnrAm_gRHzDJbjdhC9EuTPZCzhlks5vbjYLgaJpZM4PL2hj">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjf4ohb0vUeMVHD8mGUjDLaKvbIBks5vbjYLgaJpZM4PL2hj.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/roles","title":"bisq-network/roles","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/roles"}},"updates":{"snippets":[{"icon":"PERSON","message":"@oscarguindzberg in #8: ## 2019.03 report\r\n\r\nAudits:\r\n\r\n- Connection handling changes audit\r\n  - in progress \r\n- \"addr\" message support audit\r\n  - Audit report: https://github.com/bisq-network/bitcoinj/issues/28\r\n  - Bugfix: https://github.com/bisq-network/bisq/pull/2591\r\n  - Add link to this report on the source code: https://github.com/bisq-network/bitcoinj/pull/29 \r\n- fee calculation changes audit\r\n  - Commit to audit: https://github.com/oscarguindzberg/bitcoinj/commit/7dd1bfd9c3028266a5f8d1954cbf259ee3907e9b \r\n  - Fix: https://github.com/bisq-network/bitcoinj/pull/27\r\n- Tor support audit\r\n  - Audit report: https://github.com/bisq-network/bitcoinj/issues/25    \r\n  - Improvements: https://github.com/bisq-network/bitcoinj/pull/24 \r\n  - Created a couple of PR on bitcoinj upstream\r\n    - https://github.com/bitcoinj/bitcoinj/pull/1741\r\n    - https://github.com/bitcoinj/bitcoinj/pull/1742\r\n\r\nOther improvements:\r\n\r\n- Compile bitcoinj with openjdk10 \r\n  - https://github.com/bisq-network/bitcoinj/pull/23\r\n  - https://github.com/bisq-network/bisq/pull/2564 \r\n- Move clear blockstore feature to bitcoinj\r\n  - https://github.com/bisq-network/bitcoinj/pull/22 \r\n  - https://github.com/bisq-network/bisq/pull/2563 \r\n- Update testnet dns seeds https://github.com/bisq-network/bitcoinj/pull/26\r\n- Restore from seed\r\n  - Retest bitcoinj upstream bug https://github.com/bitcoinj/bitcoinj/issues/1704 because I was told it was solved. Report what is working and what is not. I had to update to java 11 because the wallet template bitcoinj subproject now requires that. It's important for us that have a benchmark wallet to know how restore from seed should work on bitcoinj.\r\n  - Complete “Restore from seed using blockstore.clear() fix” upstream PR https://github.com/bitcoinj/bitcoinj/pull/1702 (not merged yet)\r\n\r\nResearch/exploratory tasks:\r\n- Signet network research\r\n  - It is a “stable testnet” with proof of authority.\r\n  - See email thread on bitcoin core mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016734.html\r\n  - Started bitcoinj signet implementation https://github.com/oscarguindzberg/bitcoinj/tree/signet \r\n- Rebroadcasting research\r\n  - See bitcoinj mailing list https://groups.google.com/forum/#!topic/bitcoinj/lkK9N3NhoPY \r\n  - See “reject” msg removal in bitcoin core mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016701.html \r\n\r\n/cc https://github.com/bisq-network/compensation/issues/250"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/roles/issues/8#issuecomment-478048635"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/roles/issues/8#issuecomment-478048635",
"url": "https://github.com/bisq-network/roles/issues/8#issuecomment-478048635",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>