<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2614#discussion_r271290565">core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -550,10 +554,19 @@ private void addInputsAndChangeOutputForTx(Transaction tx, Coin fee, BsqCoinSele
         try {
             // TODO why is fee passed to getChange ???
             Coin change = bsqCoinSelector.getChange(fee, coinSelection);
+            if (requireChangeOutput) {
+                checkArgument(change.isPositive(),
+                        "This transaction requires a mandatory BSQ change output. " +
+                                "You are missing " + Restrictions.getMinNonDustOutput().value / 100d +
+                                " BSQ for a non dust change output.");
</pre>
<p>Better would be an input validation where a more user friendly and translated error is shown (at text field validation).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2614#discussion_r271290565">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtnkduulXIPNdcTijiJ6F3T1OkQf2ks5vc1S5gaJpZM4cXAte">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZts8EeSVRQbmgDMvWMSzGUz1zYVwBks5vc1S5gaJpZM4cXAte.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #2614"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2614#discussion_r271290565"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2614#discussion_r271290565",
"url": "https://github.com/bisq-network/bisq/pull/2614#discussion_r271290565",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>