<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2664#discussion_r272816087">core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -150,7 +150,7 @@ String getWalletAsString(boolean includePrivKeys) {
 
     public Transaction completePreparedBurnBsqTx(Transaction preparedBurnFeeTx, byte[] opReturnData)
             throws WalletException, InsufficientMoneyException, TransactionVerificationException {
-        return completePreparedProposalTx(preparedBurnFeeTx, opReturnData, null, null);
+        return completePreparedBsqTx(preparedBurnFeeTx, false, opReturnData);
</pre>
<p>That method is also called from BaseProposalFactory for proposals.<br>
I need more time to check if completePreparedBurnBsqTx could be used for proposals.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2664#discussion_r272816123">core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -150,7 +150,7 @@ String getWalletAsString(boolean includePrivKeys) {
 
     public Transaction completePreparedBurnBsqTx(Transaction preparedBurnFeeTx, byte[] opReturnData)
             throws WalletException, InsufficientMoneyException, TransactionVerificationException {
-        return completePreparedProposalTx(preparedBurnFeeTx, opReturnData, null, null);
+        return completePreparedBsqTx(preparedBurnFeeTx, false, opReturnData);
</pre>
<p>Not sure if that fix is worth the effort and risk atm, it is a very unlikely event that the input matches exactly the miner fee. And I assume it would fail anyway on the BitcoinJ side at least for the case with no outputs. Maybe we postpone that for a later time as it is not relevant for consensus anyway?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2664#pullrequestreview-223563587">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZts29o7rmD8WIWYl7ncSpjTuTEj7-ks5veWIegaJpZM4cgbB4">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtr0cipMjPCKaA3J2YlsQimW5GE_Aks5veWIegaJpZM4cgbB4.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #2664"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2664#pullrequestreview-223563587"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2664#pullrequestreview-223563587",
"url": "https://github.com/bisq-network/bisq/pull/2664#pullrequestreview-223563587",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>