<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<p>NACK</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2661#discussion_r272804510">common/src/main/java/bisq/common/storage/JsonFileManager.java</a>:</p>
<pre style='color:#555'>> @@ -78,6 +78,7 @@ public void writeToDisc(String json, String fileName) {
 
                 printWriter = new PrintWriter(tempFile);
                 printWriter.println(json);
+                printWriter.close();
</pre>
<p>It is in the finally statement:</p>
<pre><code>if (printWriter != null)
                    printWriter.close();
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2661#pullrequestreview-223551146">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtplGX-YxgpBw-KVoQCILhaRQGbHRks5veOTCgaJpZM4cgVcj">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvE7l9VJdcL02npMOUp7zG7I5mGOks5veOTCgaJpZM4cgVcj.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #2661"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2661#pullrequestreview-223551146"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2661#pullrequestreview-223551146",
"url": "https://github.com/bisq-network/bisq/pull/2661#pullrequestreview-223551146",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>