<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=23560607" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a><br>
I am not sure if we shoud merge that into 1.0.0 or keep it for later. It is not high risk but also not trivial to test. I tested quite a bit though... It should not introduce much risk as well.<br>
Lets discuss if we should add it or not. Would at least reduce confusion if some peers are out of sync as we have seen in dao-regtest last days... Also the missing file deletion of proposals, blind votes and ballots would not have lead to a recovery in current release if the cause for the issue is that one of those db files is out of sync.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2674#issuecomment-481019470">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtltKUMMnPRAea3lLjsu16Ty9Hl1vks5ve7fogaJpZM4cjKrk">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtk4r3-YLVmlqkwsgF8g7l6kBnFlGks5ve7fogaJpZM4cjKrk.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2674: @sqrrm @ripcurlx \r\nI am not sure if we shoud merge that into 1.0.0 or keep it for later. It is not high risk but also not trivial to test. I tested quite a bit though... It should not introduce much risk as well.\r\nLets discuss if we should add it or not. Would at least reduce confusion if some peers are out of sync as we have seen in dao-regtest last days... Also the missing file deletion of proposals, blind votes and ballots would not have lead to a recovery in current release if the cause for the issue is that one of those db files is out of sync."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2674#issuecomment-481019470"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2674#issuecomment-481019470",
"url": "https://github.com/bisq-network/bisq/pull/2674#issuecomment-481019470",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>