<p><b>@sqrrm</b> commented on this pull request.</p>

<p>I think it's worth adding this before 1.0 as it would avoid a lot of extra support issues from conflicted non seed nodes. It's also likely that users will be able to recover through the UI with this resync from seed feature.</p>
<p>No ACK until my comments are taken care of though.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2674#discussion_r273418065">common/src/main/java/bisq/common/storage/FileManager.java</a>:</p>
<pre style='color:#555'>>          FileUtil.renameFile(storageFile, corruptedFile);
     }
 
+    public synchronized void removeAndBackupFile(String fileName) throws IOException {
+        removeAndBackupFile(storageFile, dir, fileName, "backup_of_corrupted_data");
</pre>
<p>The argument order is <code>dbDir</code>, <code>storageFile</code>..., this looks inverted.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2674#discussion_r273426575">desktop/src/main/java/bisq/desktop/main/dao/monitor/StateMonitorView.java</a>:</p>
<pre style='color:#555'>> @@ -102,11 +115,15 @@
     public StateMonitorView(DaoStateService daoStateService,
                             DaoFacade daoFacade,
                             CycleService cycleService,
-                            PeriodService periodService) {
+                            PeriodService periodService,
+                            SeedNodeRepository seedNodeRepository,
+                            File storageDir) {
</pre>
<p>Should this be <code>@Named(Storage.STORAGE_DIR) File storageDir</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2674#pullrequestreview-224309593">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqC97SZaSkt4j673tZC3rrQHe6Hyks5vfGy-gaJpZM4cjKrk">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtsmGmLm2MqbYW4nTvmIh5XyB1Ehxks5vfGy-gaJpZM4cjKrk.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm commented on #2674"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2674#pullrequestreview-224309593"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2674#pullrequestreview-224309593",
"url": "https://github.com/bisq-network/bisq/pull/2674#pullrequestreview-224309593",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>