<p><b>@sqrrm</b> commented on this pull request.</p>

<p>I think this is mostly correct as far as I know, I'm not that familiar with the trade protocol though so I can't tell if there is some case where the deposit should be updated.</p>
<p>Also, see inline comments.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2742#discussion_r276735648">core/src/main/java/bisq/core/btc/wallet/Restrictions.java</a>:</p>
<pre style='color:#555'>>  
 import org.bitcoinj.core.Coin;
 
+import static bisq.core.payment.PaymentAccountUtil.isCryptoCurrencyAccount;
</pre>
<p>Is it appropriate to do a static import here? It probably doesn't matter in this class, I feel it makes code less readable when it's not that frequently used. More a matter of our policy than anything.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2742#discussion_r276739834">core/src/main/java/bisq/core/btc/wallet/Restrictions.java</a>:</p>
<pre style='color:#555'>> @@ -50,16 +53,25 @@ public static Coin getMinTradeAmount() {
         return MIN_TRADE_AMOUNT;
     }
 
-    public static double getDefaultBuyerSecurityDepositAsPercent() {
-        return 0.1; // 10% of trade amount.
+    public static double getDefaultBuyerSecurityDepositAsPercent(PaymentAccount paymentAccount) {
</pre>
<p>It's nice to know when nullable is allowed</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2742#discussion_r276741133">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>:</p>
<pre style='color:#555'>> @@ -282,6 +282,8 @@ public boolean initWithData(OfferPayload.Direction direction, TradeCurrency trad
         setTradeCurrencyFromPaymentAccount(paymentAccount);
         tradeCurrencyCode.set(this.tradeCurrency.getCode());
 
+        setTradeCurrencyFromPaymentAccount(paymentAccount);
</pre>
<p>I don't understand why this needs to be done twice, it's set three lines up.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2742#pullrequestreview-228379961">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXQE734IWAB45SGIDLPRCP6NANCNFSM4HG5X3GQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVMT3CHW7F6I2YMZO3PRCP6NANCNFSM4HG5X3GQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm commented on #2742"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2742#pullrequestreview-228379961"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2742#pullrequestreview-228379961",
"url": "https://github.com/bisq-network/bisq/pull/2742#pullrequestreview-228379961",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>