<blockquote>
<p>utACK</p>
<p>As a reviewer I prefer when the previous commits are kept and just add a new one rather than a force push. Easier to follow which changes were made after comments were made that way.</p>
</blockquote>
<p>True - I wanted to reduce the amount of commits, but in a PR that gets reviewed it makes it harder to follow.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2742#issuecomment-484814483">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXKHVCBUON3UUJU34DPRGBVPANCNFSM4HG5X3GQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVZQPFAKV4GFW5MJK3PRGBVPANCNFSM4HG5X3GQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx in #2742: \u003e utACK\r\n\u003e \r\n\u003e As a reviewer I prefer when the previous commits are kept and just add a new one rather than a force push. Easier to follow which changes were made after comments were made that way.\r\n\r\nTrue - I wanted to reduce the amount of commits, but in a PR that gets reviewed it makes it harder to follow."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2742#issuecomment-484814483"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2742#issuecomment-484814483",
"url": "https://github.com/bisq-network/bisq/pull/2742#issuecomment-484814483",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>