<p><b>@sqrrm</b> commented on this pull request.</p>

<p>Looks like a reasonable approach. Quite simple and not tying in to other parts.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2768#discussion_r277793449">core/src/main/java/bisq/core/account/sign/SignedWitnessService.java</a>:</p>
<pre style='color:#555'>> +                addToMap((SignedWitness) payload);
+        });
+
+        // At startup the P2PDataStorage initializes earlier, otherwise we ge the listener called.
+        p2PService.getP2PDataStorage().getAppendOnlyDataStoreMap().values().forEach(e -> {
+            if (e instanceof SignedWitness)
+                addToMap((SignedWitness) e);
+        });
+    }
+
+
+    ///////////////////////////////////////////////////////////////////////////////////////////
+    // API
+    ///////////////////////////////////////////////////////////////////////////////////////////
+
+    // Arbitrators sign with EC key
</pre>
<p>Could you add a short explanation why arbitrators are using EC keys?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2768#discussion_r277799992">core/src/main/java/bisq/core/account/sign/SignedWitnessService.java</a>:</p>
<pre style='color:#555'>> +    public Set<SignedWitness> getTrustedPeerSignedWitnessSet(AccountAgeWitness accountAgeWitness) {
+        return signedWitnessMap.values().stream()
+                .filter(e -> !e.isSignedByArbitrator())
+                .filter(e -> Arrays.equals(e.getWitnessHash(), accountAgeWitness.getHash()))
+                .collect(Collectors.toSet());
+    }
+
+    // We go one level up by using the signer Key to lookup for SignedWitness objects which contain the signerKey as
+    // witnessOwnerPubKey
+    public Set<SignedWitness> getSignedWitnessSetBySignerPubKey(byte[] signerPubKey) {
+        return signedWitnessMap.values().stream()
+                .filter(e -> Arrays.equals(e.getWitnessOwnerPubKey(), signerPubKey))
+                .collect(Collectors.toSet());
+    }
+
+    public boolean isValidAccountAgeWitness(AccountAgeWitness accountAgeWitness) {
</pre>
<p>There need to be a break in case of circular signing. If someone creates two witnesses that sign each other I think this recursion would go into an infinite loop.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2768#pullrequestreview-229696928">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUIJPMPEVKXWSW77HDPR5FDNANCNFSM4HHUFKCA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNRA53HMFIC5MYUXT4TPR5FDNANCNFSM4HHUFKCA.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm commented on #2768"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2768#pullrequestreview-229696928"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2768#pullrequestreview-229696928",
"url": "https://github.com/bisq-network/bisq/pull/2768#pullrequestreview-229696928",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>