<p>2019.04 report</p>
<ul>
<li>bisq’s bitcoinj 0.14.7 connection handling changes audit
<ul>
<li>Audit: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="427209686" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/30" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bitcoinj/issues/30/hovercard" href="https://github.com/bisq-network/bitcoinj/issues/30">bisq-network/bitcoinj#30</a></li>
<li>Fixes: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="428418400" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/31" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/31/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/31">bisq-network/bitcoinj#31</a></li>
</ul>
</li>
<li>Migrate to bitcoinj 0.15
<ul>
<li>Use bisq's bitcoinj 0.15 in bisq
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="436333065" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2772" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2772/hovercard" href="https://github.com/bisq-network/bisq/pull/2772">bisq-network/bisq#2772</a></li>
</ul>
</li>
<li>Rebase bisq’s bitcoinj from bitcoinj 0.15.1
<ul>
<li><a href="https://github.com/bisq-network/bitcoinj/commits/bisq_0.15.1">https://github.com/bisq-network/bitcoinj/commits/bisq_0.15.1</a></li>
<li>All commits added by Oscar have a description linking to the commit on the 0.14.7 branch that originated it.</li>
<li>Many commits were combined.</li>
<li>Many commits were already included on upstream bitcoinj 0.15.1</li>
</ul>
</li>
</ul>
</li>
<li>Broadcasting DAO proposal txs / bitcoinj "deprecated" confidence problem
<ul>
<li>Report and investigate bug: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="429305444" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2639" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2639/hovercard" href="https://github.com/bisq-network/bisq/issues/2639">bisq-network/bisq#2639</a></li>
<li>Create Fix PR (need more analysis) <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="429444345" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bitcoinj/issues/32" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bitcoinj/pull/32/hovercard" href="https://github.com/bisq-network/bitcoinj/pull/32">bisq-network/bitcoinj#32</a></li>
<li>Create upstream issue: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="429476032" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1769" data-hovercard-type="issue" data-hovercard-url="/bitcoinj/bitcoinj/issues/1769/hovercard" href="https://github.com/bitcoinj/bitcoinj/issues/1769">bitcoinj/bitcoinj#1769</a></li>
<li>Tests to prove the problem: <a href="https://github.com/oscarguindzberg/bitcoinj/commits/tx-confidence-cache">https://github.com/oscarguindzberg/bitcoinj/commits/tx-confidence-cache</a></li>
</ul>
</li>
<li>Upstream PR
<ul>
<li>Wallet.findKeyFromPubKeyHash(): Fix ScriptType, use P2PKH.
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432103722" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1782" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1782/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1782">bitcoinj/bitcoinj#1782</a></li>
</ul>
</li>
</ul>
</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/roles/issues/8#issuecomment-490628545">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWFAEQIF4CIHJ2WUUTPUMWFLANCNFSM4DZPNBRQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNXTDSBCDMU44GAGQODPUMWFLA5CNFSM4DZPNBR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODU7GLQI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/roles/issues/8#issuecomment-490628545",
"url": "https://github.com/bisq-network/roles/issues/8#issuecomment-490628545",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>