<p>I <em>think</em> I know what's happening:</p>
<ul>
<li><code>TradeManager</code> adds trade in <code>handlePayDepositRequest()</code></li>
<li>Price disagreement leads to NullPointerException (see <a href="https://github.com/bisq-network/bisq/issues/2910#issuecomment-505533956" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2910/hovercard">my comment on #2910</a>)</li>
<li>Thus, <code>cleanupTradableOnFault()</code> never gets called in <a href="https://github.com/bisq-network/bisq/blob/v1.1.2/core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java#L173">TradeProtocol.java#L173</a> and the trade falsely stays in the TradeManager/Open Trades list</li>
<li>On the next <code>handlePayDepositRequest()</code>, the trade gets added <em>again</em>, so we have it in the TradeManager <em>twice</em>: One correct version and one version without a price</li>
</ul>
<p>Thoughts?<br>
If this is correct, do you think my fix of the underlying NPE in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="461989251" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2928" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2928/hovercard" href="https://github.com/bisq-network/bisq/pull/2928">#2928</a> is enough or should we ensure that whenever a trade is added to the TradeManager's <code>tradableList</code>, already existing entries with the same ID are removed first to prevent possible similar issues like this in the future?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2926?email_source=notifications&email_token=AJFFTNXENAMCMOIK225VQ4LP447SVA5CNFSM4H35JWQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3W45I#issuecomment-506949237">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV6W46L4IMV3M5DNGDP447SVANCNFSM4H35JWQQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUZ3EYOZGAJKBWGDPDP447SVA5CNFSM4H35JWQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3W45I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2926?email_source=notifications\u0026email_token=AJFFTNXENAMCMOIK225VQ4LP447SVA5CNFSM4H35JWQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3W45I#issuecomment-506949237",
"url": "https://github.com/bisq-network/bisq/pull/2926?email_source=notifications\u0026email_token=AJFFTNXENAMCMOIK225VQ4LP447SVA5CNFSM4H35JWQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3W45I#issuecomment-506949237",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>