<p>Seeing an oszillating pattern of broadcast message numbers in <a href="https://monitor.bisq.network/d/wTDl6T_iz/p2p-stats?refresh=30s&orgId=1" rel="nofollow">monitoring</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1449498" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ManfredKarrer">@ManfredKarrer</a> and I suspected that the pattern might be caused by the DoS protection mechanisms in place.</p>
<p>This PR introduces a new message that containing a number of existing messages. The hopes are:</p>
<ul>
<li>less connection setup overhead on the network level leading to less network load and hopefully better performance</li>
<li>not to spread the bursts of e.g. RefreshOffer messages over a long time</li>
</ul>
<p>In case this change has a bad effect on network stability (although we do not believe it is going to) we can simply remove the newly created <code>Capability</code> in a future release and thus, quickly get rid of the feature.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2939'>https://github.com/bisq-network/bisq/pull/2939</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Added EnvelopeOfEnvelopes Network Message</li>
  <li>Sketch of businesslogic regarding EnvelopeOfEnvelopes</li>
  <li>Use EnvelopeOfEnvelopes message type</li>
  <li>Split on resulting message size</li>
  <li>Still maintain DoS protection</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2939/files#diff-0">common/src/main/java/bisq/common/app/Capability.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2939/files#diff-1">common/src/main/proto/pb.proto</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2939/files#diff-2">core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2939/files#diff-3">core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java</a>
    (1)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2939/files#diff-4">p2p/src/main/java/bisq/network/p2p/EnvelopeOfEnvelopes.java</a>
    (83)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2939/files#diff-5">p2p/src/main/java/bisq/network/p2p/network/Connection.java</a>
    (71)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2939.patch'>https://github.com/bisq-network/bisq/pull/2939.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2939.diff'>https://github.com/bisq-network/bisq/pull/2939.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2939?email_source=notifications&email_token=AJFFTNUBVRJV3VHASQ5RTVDP6CHAVA5CNFSM4H6TK222YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5VB3WQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXHS6JUJPMO4QZOU63P6CHAVANCNFSM4H6TK22Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNTLNXRONBGE6MXSAMLP6CHAVA5CNFSM4H6TK222YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5VB3WQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2939?email_source=notifications\u0026email_token=AJFFTNUBVRJV3VHASQ5RTVDP6CHAVA5CNFSM4H6TK222YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5VB3WQ",
"url": "https://github.com/bisq-network/bisq/pull/2939?email_source=notifications\u0026email_token=AJFFTNUBVRJV3VHASQ5RTVDP6CHAVA5CNFSM4H6TK222YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5VB3WQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>