<p><b>@blabno</b> requested changes on this pull request.</p>

<p>NACK per comments</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2961#discussion_r304300902">assets/src/main/java/bisq/asset/coins/Emercoin.java</a>:</p>
<pre style='color:#555'>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.Coin;
+import bisq.asset.DefaultAddressValidator;
+
+public class Emercoin extends Coin {
+
+    public Emercoin() {
+        super("Emercoin", "EMC", new DefaultAddressValidator());
</pre>
<p>Do not use deprecated validator.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2961#discussion_r304301026">assets/src/test/java/bisq/asset/coins/EmercoinTest.java</a>:</p>
<pre style='color:#555'>> + * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.AbstractAssetWithDefaultValidatorTest;
+
+public class EmercoinTest extends AbstractAssetWithDefaultValidatorTest {
+
+    public EmercoinTest() {
</pre>
<p>Test class is missing test methods.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2961#discussion_r304301095">core/src/main/java/bisq/core/locale/CurrencyUtil.java</a>:</p>
<pre style='color:#555'>> @@ -131,6 +131,7 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) {
         result.add(new CryptoCurrency("BEAM", "Beam"));
         result.add(new CryptoCurrency("DASH", "Dash"));
         result.add(new CryptoCurrency("DCR", "Decred"));
+        result.add(new CryptoCurrency("EMC", "Emercoin"));
</pre>
<p>Do not touch this file.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2961?email_source=notifications&email_token=AJFFTNRNPSW4DJ42QNZNDNTP73P6DA5CNFSM4IDC2XRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VY7PI#pullrequestreview-262901693">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSXCVYXXMIXXW4O2Y3P73P6DANCNFSM4IDC2XRA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNR5VQBAKISOJTJIUSLP73P6DA5CNFSM4IDC2XRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VY7PI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2961?email_source=notifications\u0026email_token=AJFFTNRNPSW4DJ42QNZNDNTP73P6DA5CNFSM4IDC2XRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VY7PI#pullrequestreview-262901693",
"url": "https://github.com/bisq-network/bisq/pull/2961?email_source=notifications\u0026email_token=AJFFTNRNPSW4DJ42QNZNDNTP73P6DA5CNFSM4IDC2XRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VY7PI#pullrequestreview-262901693",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>