<p>Hello everyone.</p>
<p>I think a clue to this issue may be found in the <strong><code>bisq.core.btc.wallet.TxBroadcaster</code></strong> class in the <strong><code>default void onTimeout(TxBroadcastTimeoutException exception)</code></strong> method. The paraphrased comment is below:</p>
<blockquote>
<p>We optimistically assume that the tx broadcast succeeds later and call onSuccess on the callback handler.<br>
This behaviour carries less potential problems than if we would trigger a failure (e.g. which would cause<br>
a failed create offer attempt or failed take offer attempt).<br>
We have no guarantee how long it will take to get the information that sufficiently many BTC nodes have<br>
reported back to BitcoinJ that the tx is in their mempool.<br>
In normal situations that's very fast but in some cases it can take minutes (mostly related to Tor<br>
connection issues). So if we just go on in the application logic and treat it as successful and the<br>
tx will be broadcast successfully later all is fine.<br>
If it will fail to get broadcast, it will lead to a failure state, the same as if we would trigger a<br>
failure due the timeout.<br>
So we can assume that this behaviour will lead to less problems as otherwise.<br>
Long term we should implement better monitoring for Tor and the provided Bitcoin nodes to find out<br>
why those delays happen and add some rollback behaviour to the app state in case the tx will never<br>
get broadcast.</p>
</blockquote>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/commit/0ac2cbf499855c3abad48dbd52f3dac4ee924b2c?email_source=notifications&email_token=AJFFTNTCTQ3KO5LEPOSVZQLQAF6P5A5CNFSM4IFD4CS2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAYZZC#commitcomment-34367266">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVMQM2ALGF2J4PGBGLQAF6P5ANCNFSM4IFD4CSQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNWCYQ5LSW2QXMASYEDQAF6P5A5CNFSM4IFD4CS2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAYZZC.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/commit/0ac2cbf499855c3abad48dbd52f3dac4ee924b2c?email_source=notifications\u0026email_token=AJFFTNTCTQ3KO5LEPOSVZQLQAF6P5A5CNFSM4IFD4CS2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAYZZC#commitcomment-34367266",
"url": "https://github.com/bisq-network/bisq/commit/0ac2cbf499855c3abad48dbd52f3dac4ee924b2c?email_source=notifications\u0026email_token=AJFFTNTCTQ3KO5LEPOSVZQLQAF6P5A5CNFSM4IFD4CS2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAYZZC#commitcomment-34367266",
"name": "View Commit"
},
"description": "View this Commit on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>