<p>While it's nice to clean up the code I wonder if it's really worthwhile right now. I see issues with current trade protocol and performance issues as more urgent. People are having problem at startup with the app not starting or being very slow and there are a few bugs out there causing people to lose money trying to initiate trades or transactions failing for unclear reasons.</p>
<p>This kind of refactor is probably a lot easier to understand though, and perhaps a good start rather than diving straight into the most sensitive parts of the code. All depends on how much work and the risk to stability.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/2996?email_source=notifications&email_token=AJFFTNRDWGVCDDHZVC54TSLQBBBKZA5CNFSM4IGOHSFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WEGGI#issuecomment-514605849">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTHJYIPKSJ373G7NKLQBBBKZANCNFSM4IGOHSFA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUV26CKZ2ID355ZMK3QBBBKZA5CNFSM4IGOHSFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WEGGI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/2996?email_source=notifications\u0026email_token=AJFFTNRDWGVCDDHZVC54TSLQBBBKZA5CNFSM4IGOHSFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WEGGI#issuecomment-514605849",
"url": "https://github.com/bisq-network/bisq/issues/2996?email_source=notifications\u0026email_token=AJFFTNRDWGVCDDHZVC54TSLQBBBKZA5CNFSM4IGOHSFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WEGGI#issuecomment-514605849",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>