<p>reasons for mockito:</p>
<ul>
<li>I know mockito best from previous projects, so I know pretty well how to convert all tests to mockito, with jmockit I would have to read up on it.</li>
<li>Mockito seems to be the most used mocking lib in java land</li>
<li>Our jmockit setup is really complicated, we use 2 different jmockit versions, one in p2p and a different one in the other modules.</li>
<li>Jmockit uses an javaagent which not always works so well in the IDE</li>
</ul>
<p>last reason and for me the main reason: jmockit and powermock both have powerful static mocking methods which mockito does not have by design, and I think simpler mocking enforces better design.</p>
<p>It is possible that not all these reasons are true or still true because i don't know much about jmockit, i just saw that we have a pretty complicated setup.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/3025?email_source=notifications&email_token=AJFFTNW7T42YQXT74MLLHCTQB3WATA5CNFSM4IHQXYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AWNCQ#issuecomment-515991178">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS3A2O3FGOAEBKTGPLQB3WATANCNFSM4IHQXYHA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNS2HF4OEN4RJUX35ZLQB3WATA5CNFSM4IHQXYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AWNCQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/3025?email_source=notifications\u0026email_token=AJFFTNW7T42YQXT74MLLHCTQB3WATA5CNFSM4IHQXYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AWNCQ#issuecomment-515991178",
"url": "https://github.com/bisq-network/bisq/issues/3025?email_source=notifications\u0026email_token=AJFFTNW7T42YQXT74MLLHCTQB3WATA5CNFSM4IHQXYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AWNCQ#issuecomment-515991178",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>