<p>Finally got the monitor to state that is does not kill some of its metrics after a few hours.</p>
<p>Furthermore, I refactored the P2P Roundtriptime metric so it does not always report all seeds as offline if one or more of them takes too long to respond (the issue showed up just recently, seems that our seeds are under heavier load than they have been).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3045'>https://github.com/bisq-network/bisq/pull/3045</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactored P2PRTT metric</li>
  <li>Fixed NullPointer in corner case</li>
  <li>Fix stopping the schedule because of exception</li>
  <li>Fixed NullPointerEx of corner case</li>
  <li>Remove tiny gap in time for missing a message</li>
  <li>Logging cosmetics</li>
  <li>Remove debug statement</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3045/files#diff-0">monitor/src/main/java/bisq/monitor/Metric.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3045/files#diff-1">monitor/src/main/java/bisq/monitor/metric/MarketStats.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3045/files#diff-2">monitor/src/main/java/bisq/monitor/metric/P2PRoundTripTime.java</a>
    (165)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3045/files#diff-3">monitor/src/main/java/bisq/monitor/metric/P2PSeedNodeSnapshot.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3045/files#diff-4">monitor/src/main/java/bisq/monitor/metric/P2PSeedNodeSnapshotBase.java</a>
    (8)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3045.patch'>https://github.com/bisq-network/bisq/pull/3045.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3045.diff'>https://github.com/bisq-network/bisq/pull/3045.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3045?email_source=notifications&email_token=AJFFTNVBCSSVKYQBI2PDMBTQCLEWNA5CNFSM4IIP2GMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZVANQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWVIS27MLSGOVAJLITQCLEWNANCNFSM4IIP2GMA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNU64XTDQD7JRI5FCE3QCLEWNA5CNFSM4IIP2GMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZVANQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3045?email_source=notifications\u0026email_token=AJFFTNVBCSSVKYQBI2PDMBTQCLEWNA5CNFSM4IIP2GMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZVANQ",
"url": "https://github.com/bisq-network/bisq/pull/3045?email_source=notifications\u0026email_token=AJFFTNVBCSSVKYQBI2PDMBTQCLEWNA5CNFSM4IIP2GMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZVANQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>