<p>This PR adds features that allow the user to</p>
<ul>
<li>backup her current onion address,</li>
<li>restore a previously onion address backup</li>
<li>and even create a completely new onion address</li>
</ul>
<p>all from within the GUI.</p>
<p><strong>How do you make sure that there are no more open offers or even ongoing trades before you import/renew the address?</strong><br>
I don't. I have reworked the P2P backend so that a single client can have multiple hidden services up and running at any time. If the user renews/imports an onion address, a new hidden service is started. Hidden services are only removed once no more open offers or ongoing trades are there (checked for after every completed trade/closed offer).</p>
<p><strong>All during runtime?</strong><br>
No. A restart is required for the import and renew features.</p>
<p>Contains DE translations as well.</p>
<p>Here are some impressions:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/1070734/62289942-56f0ea00-b460-11e9-86b7-8bd5dc91324e.png"><img src="https://user-images.githubusercontent.com/1070734/62289942-56f0ea00-b460-11e9-86b7-8bd5dc91324e.png" alt="Screenshot from 2019-08-01 13-28-50" style="max-width:100%;"></a><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/1070734/62289997-81db3e00-b460-11e9-83b7-f5ed12f731a6.png"><img src="https://user-images.githubusercontent.com/1070734/62289997-81db3e00-b460-11e9-83b7-f5ed12f731a6.png" alt="Screenshot from 2019-08-01 13-29-57" style="max-width:100%;"></a><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/1070734/62289802-f792da00-b45f-11e9-954f-19752da0742d.png"><img src="https://user-images.githubusercontent.com/1070734/62289802-f792da00-b45f-11e9-954f-19752da0742d.png" alt="Screenshot from 2019-07-30 12-09-40" style="max-width:100%;"></a></p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #1055.">closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="279166297" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1055" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/1055/hovercard" href="https://github.com/bisq-network/bisq/issues/1055">#1055</a>, <span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #1056.">closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="279166883" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1056" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/1056/hovercard" href="https://github.com/bisq-network/bisq/issues/1056">#1056</a>, subsequently <span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #909.">closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="251542428" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/909" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/909/hovercard" href="https://github.com/bisq-network/bisq/issues/909">#909</a> and does take care of a lot of preparation work for <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="453097697" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2873" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2873/hovercard" href="https://github.com/bisq-network/bisq/issues/2873">#2873</a>.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/3044'>https://github.com/bisq-network/bisq/pull/3044</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Gui mockup</li>
<li>Refactored starting Tor</li>
<li>Removed double assignment of nodeAddressProperty</li>
<li>Remove unnecessary field</li>
<li>Migrate to new folder structure of HSs</li>
<li>Only report HSready when all HS are started</li>
<li>Report TorNode ready once we now our address</li>
<li>Formatting cosmetics</li>
<li>Renew address is active</li>
<li>Added clearHS stub</li>
<li>First-time launch of Bisq works again</li>
<li>Report unused HS on trade/offer close</li>
<li>Report HS in use instead of unused ones</li>
<li>Clear unused hidden services</li>
<li>Reenable rolling backup</li>
<li>Add informative popup before renew</li>
<li>HS backup active</li>
<li>HS restore active</li>
<li>DE translations</li>
<li>Handle duplicate hidden service situation</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-0">core/src/main/java/bisq/core/offer/OpenOfferManager.java</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-1">core/src/main/java/bisq/core/trade/TradeManager.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-2">core/src/main/resources/i18n/displayStrings.properties</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-3">core/src/main/resources/i18n/displayStrings_de.properties</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-4">core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-5">desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.fxml</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-6">desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java</a>
(53)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-7">monitor/src/main/java/bisq/monitor/AvailableTor.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-8">p2p/src/main/java/bisq/network/p2p/P2PService.java</a>
(37)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-9">p2p/src/main/java/bisq/network/p2p/network/LocalhostNetworkNode.java</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-10">p2p/src/main/java/bisq/network/p2p/network/NetworkNode.java</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-11">p2p/src/main/java/bisq/network/p2p/network/NewTor.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-12">p2p/src/main/java/bisq/network/p2p/network/RunningTor.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-13">p2p/src/main/java/bisq/network/p2p/network/TorMode.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3044/files#diff-14">p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java</a>
(325)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/3044.patch'>https://github.com/bisq-network/bisq/pull/3044.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/3044.diff'>https://github.com/bisq-network/bisq/pull/3044.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3044?email_source=notifications&email_token=AJFFTNS56JSGYURXCAJQPWLQCLDRFA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZS7KA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXRFY3PBBINQGADWITQCLDRFANCNFSM4IIPXYQQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUUTB6TNQ7RJKSPWTLQCLDRFA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZS7KA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3044?email_source=notifications\u0026email_token=AJFFTNS56JSGYURXCAJQPWLQCLDRFA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZS7KA",
"url": "https://github.com/bisq-network/bisq/pull/3044?email_source=notifications\u0026email_token=AJFFTNS56JSGYURXCAJQPWLQCLDRFA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCZS7KA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>