<p><b>@freimair</b> requested changes on this pull request.</p>

<p>NullPointerEx due to error in indexing. See the comment.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3040#discussion_r310919340">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java</a>:</p>
<pre style='color:#555'>>                  columns[0] = model.getTradeId(item);
                 columns[1] = model.getDate(item);
                 columns[2] = model.getAmount(item);
                 columns[3] = model.getPrice(item);
                 columns[4] = model.getVolume(item);
+                               columns[5] = model.getTxFee(item);
+                               columns[6] = model.getMakerFee(item);
+                               columns[7] = model.getBuyerSecurityDeposit(item);
+                               columns[8] = model.getSellerSecurityDeposit(item);
                 columns[5] = model.getDirectionLabel(item);
</pre>
<p>there is something wrong with the indexing here. you added 5,6,7,8, yet, the last lines reassign 5 and 6. Ultimately resulting in a</p>
<pre><code>java.lang.NullPointerException
        at com.googlecode.jcsv.writer.internal.CSVColumnJoinerImpl.joinColumns(CSVColumnJoinerImpl.java:30)
        at com.googlecode.jcsv.writer.internal.CSVWriterImpl.write(CSVWriterImpl.java:38)
        at com.googlecode.jcsv.writer.internal.CSVWriterImpl.writeAll(CSVWriterImpl.java:29)
        at bisq.desktop.util.GUIUtil.exportCSV(GUIUtil.java:266)
</code></pre>
<p>because 9 and 10 stay unassigned (null).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3040?email_source=notifications&email_token=AJFFTNSF6SLFXKZQWZ24AFDQDETOZA5CNFSM4IIK6VE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAU2CJI#pullrequestreview-271163685">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVQRGYYSHGYFAEWMK3QDETOZANCNFSM4IIK6VEQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVHUBKIJBFCV6NDABLQDETOZA5CNFSM4IIK6VE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAU2CJI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3040?email_source=notifications\u0026email_token=AJFFTNSF6SLFXKZQWZ24AFDQDETOZA5CNFSM4IIK6VE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAU2CJI#pullrequestreview-271163685",
"url": "https://github.com/bisq-network/bisq/pull/3040?email_source=notifications\u0026email_token=AJFFTNSF6SLFXKZQWZ24AFDQDETOZA5CNFSM4IIK6VE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAU2CJI#pullrequestreview-271163685",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>