<p>Regarding static code analysis I usually used several tools together as each had some checks that others did not. Those were :</p>
<ul>
<li><a href="https://checkstyle.sourceforge.io/" rel="nofollow">https://checkstyle.sourceforge.io/</a></li>
<li><a href="https://pmd.github.io/" rel="nofollow">https://pmd.github.io/</a></li>
<li><a href="http://findbugs.sourceforge.net/" rel="nofollow">http://findbugs.sourceforge.net/</a></li>
</ul>
<p>For the long run I think we should unit test everything at least in the core. With the UI will have to see how time consuming it is to test view classes thoroughly.<br>
In the beginning the main obstacle, for writing good unit tests, will be the tangles between different components and layers of code. But I think we should not get discouraged by that, because well tested code will pay off in the long run.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/proposals/issues/105?email_source=notifications&email_token=AJFFTNSGAWWPJJJJDDEAA5LQEF7R7A5CNFSM4IJUYIF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C5R5Q#issuecomment-520476918">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNULRDD6TYP44WXOJNLQEF7R7ANCNFSM4IJUYIFQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNRWZMVTZGSQD7Y7VKTQEF7R7A5CNFSM4IJUYIF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C5R5Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/proposals/issues/105?email_source=notifications\u0026email_token=AJFFTNSGAWWPJJJJDDEAA5LQEF7R7A5CNFSM4IJUYIF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C5R5Q#issuecomment-520476918",
"url": "https://github.com/bisq-network/proposals/issues/105?email_source=notifications\u0026email_token=AJFFTNSGAWWPJJJJDDEAA5LQEF7R7A5CNFSM4IJUYIF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C5R5Q#issuecomment-520476918",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>