<p>the app still throws a NPE at startup, on jdk 12, but runs fine on jdk11<br>
build and test suite works on jdk10,11,12</p>
<p>had to disable a very small amount of tests that were not so easy to convert.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3081'>https://github.com/bisq-network/bisq/pull/3081</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>WIP remove powermock</li>
  <li>remove powermock from core.</li>
  <li>remove more powermock and jmockit tests.</li>
  <li>remove powermock from gradle file</li>
  <li>remove jmockit</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-0">build.gradle</a>
    (28)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-1">core/src/main/java/bisq/core/dao/governance/period/PeriodService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-2">core/src/main/java/bisq/core/offer/OfferPayload.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-3">core/src/main/java/bisq/core/user/Preferences.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-4">core/src/test/java/bisq/core/arbitration/ArbitratorManagerTest.java</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-5">core/src/test/java/bisq/core/btc/TxFeeEstimationServiceTest.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-6">core/src/test/java/bisq/core/btc/nodes/BtcNodesSetupPreferencesTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-7">core/src/test/java/bisq/core/dao/governance/ballot/BallotListServiceTest.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-8">core/src/test/java/bisq/core/dao/node/full/BlockParserTest.java</a>
    (47)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-9">core/src/test/java/bisq/core/dao/state/DaoStateSnapshotServiceTest.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-10">core/src/test/java/bisq/core/offer/OfferTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-11">core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-12">core/src/test/java/bisq/core/payment/PaymentAccountsTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-13">core/src/test/java/bisq/core/payment/ReceiptPredicatesTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-14">core/src/test/java/bisq/core/payment/ReceiptValidatorTest.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-15">core/src/test/java/bisq/core/payment/TradeLimitsTest.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-16">core/src/test/java/bisq/core/trade/TradableListTest.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-17">core/src/test/java/bisq/core/user/PreferencesTest.java</a>
    (8)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-18">core/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker</a>
    (1)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-19">desktop/src/main/java/bisq/desktop/main/offer/MakerFeeMaker.java</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-20">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-21">desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-22">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-23">desktop/src/test/java/bisq/desktop/main/funds/transactions/TransactionAwareTradeTest.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-24">desktop/src/test/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModelTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-25">desktop/src/test/java/bisq/desktop/main/market/spread/SpreadViewModelTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-26">desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java</a>
    (33)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-27">desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModelTest.java</a>
    (27)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-28">desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-29">desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-30">desktop/src/test/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModelTest.java</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-31">desktop/src/test/java/bisq/desktop/main/settings/preferences/PreferencesViewModelTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-32">desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-33">desktop/src/test/java/bisq/desktop/util/CurrencyListTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-34">desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java</a>
    (26)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-35">desktop/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3081/files#diff-36">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageTest.java</a>
    (24)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3081.patch'>https://github.com/bisq-network/bisq/pull/3081.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3081.diff'>https://github.com/bisq-network/bisq/pull/3081.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3081?email_source=notifications&email_token=AJFFTNUD4MZVDJ6JGACCWKDQELX33A5CNFSM4ILNGRG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HFASAUA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNR3PKJHUKGBJLAZ4Y3QELX33ANCNFSM4ILNGRGQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNSM7LXDTN6WOICQZWLQELX33A5CNFSM4ILNGRG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HFASAUA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3081?email_source=notifications\u0026email_token=AJFFTNUD4MZVDJ6JGACCWKDQELX33A5CNFSM4ILNGRG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HFASAUA",
"url": "https://github.com/bisq-network/bisq/pull/3081?email_source=notifications\u0026email_token=AJFFTNUD4MZVDJ6JGACCWKDQELX33A5CNFSM4ILNGRG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HFASAUA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>