<blockquote>
<p>utACK</p>
<p>Don't know how the 'mergers' think about this but wouldn't it be cleaner if you rebase this on your previous PR (this PR doesn't only contain the inject publickeyring changes) ? You could add a 'blocked by <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="44837901" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/123" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/123/hovercard" href="https://github.com/bisq-network/bisq/issues/123">#123</a>' comment so it doesn't get merged before the parent. Would make for cleaner diffs</p>
</blockquote>
<p>i can only rebase this pr once the other one is in master. and then i will rebase it and it will be much smaller.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3086?email_source=notifications&email_token=AJFFTNRZXRE2ENRCYVA7U2DQEP6KBA5CNFSM4ILT5NMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4IWP7Y#issuecomment-521234431">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWRNRDZHAPVRHBY2TTQEP6KBANCNFSM4ILT5NMA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNXF5EG4TART3PD7GN3QEP6KBA5CNFSM4ILT5NMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4IWP7Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3086?email_source=notifications\u0026email_token=AJFFTNRZXRE2ENRCYVA7U2DQEP6KBA5CNFSM4ILT5NMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4IWP7Y#issuecomment-521234431",
"url": "https://github.com/bisq-network/bisq/pull/3086?email_source=notifications\u0026email_token=AJFFTNRZXRE2ENRCYVA7U2DQEP6KBA5CNFSM4ILT5NMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4IWP7Y#issuecomment-521234431",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>