<p><b>@freimair</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3044#discussion_r315636683">p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java</a>:</p>
<pre style='color:#555'>> }
- return null;
- });
- hiddenServiceSocket.addReadyListener(hiddenServiceSocket1 -> { onHSReady.countDown(); return null;} );
- log.info("It will take some time for the HS to be reachable (~40 seconds). You will be notified about this");
- return nodeAddress;
+ }.start();
+ } catch (final Exception e) {
+ log.error(e.toString());
+ e.printStackTrace();
+ }
+ return null;
+ });
+ hiddenServiceSocket.addReadyListener(hiddenServiceSocket1 -> {
</pre>
<p>because of readability. separation of concerns.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3044?email_source=notifications&email_token=AJFFTNX4DTLXG3DBBI3444DQFPICZA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCCC4UQ#discussion_r315636683">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS4B7HZ3HFDMWRQ7KLQFPICZANCNFSM4IIPXYQQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNRCD4535KKAI3OEWG3QFPICZA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCCC4UQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3044?email_source=notifications\u0026email_token=AJFFTNX4DTLXG3DBBI3444DQFPICZA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCCC4UQ#discussion_r315636683",
"url": "https://github.com/bisq-network/bisq/pull/3044?email_source=notifications\u0026email_token=AJFFTNX4DTLXG3DBBI3444DQFPICZA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCCC4UQ#discussion_r315636683",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>