<blockquote>
<p>I guess we would rather... have no full address validation rather than adding a new dependency.</p>
</blockquote>
<p>If I were to use a regex validator, it would necessarily accept addresses which the actual validator would reject: you can't check internal hash codes with a regex. That said, I do not know what the actual effects would be if the bisq validator accepted addresses which are in fact invalid. If the consequences are acceptable, it would be easy to implement.</p>
<p>Doing so will necessitate changing the test suite, many of the invalid cases of which are single-character replacements which invalidate the internal hash.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=54061429" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/battleofwizards">@battleofwizards</a> would that be more palatable?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3110?email_source=notifications&email_token=AJFFTNUWVUOWHMXQMRFX6VLQF7Z3JA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ANO4I#issuecomment-524343153">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRRAN3UCU44LYV4YEDQF7Z3JANCNFSM4INQXLPA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVMIJP6FUI45QMP54DQF7Z3JA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ANO4I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3110?email_source=notifications\u0026email_token=AJFFTNUWVUOWHMXQMRFX6VLQF7Z3JA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ANO4I#issuecomment-524343153",
"url": "https://github.com/bisq-network/bisq/pull/3110?email_source=notifications\u0026email_token=AJFFTNUWVUOWHMXQMRFX6VLQF7Z3JA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ANO4I#issuecomment-524343153",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>