<p><b>@HarryMacfinned</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3134#discussion_r317345227">desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java</a>:</p>
<pre style='color:#555'>> +
+ public PhoneNumberValidator(String isoCountryCode) {
+ this.isoCountryCode = isoCountryCode;
+ this.countryCallingCodes = new CountryCallingCodes();
+ this.callingCode = countryCallingCodes.getCallingCode(isoCountryCode);
+ this.normalizedCallingCode = countryCallingCodes.getNormalizedCallingCode(isoCountryCode);
+ }
+
+
+ @Override
+ public ValidationResult validate(String input) {
+ normalizedPhoneNumber = null;
+ ValidationResult result = super.validate(input);
+ if (!result.isValid) {
+ return result;
+ }
</pre>
<p>There are some style reco at <a href="https://github.com/bisq-network/style">https://github.com/bisq-network/style</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3134?email_source=notifications&email_token=AJFFTNTU5X7IY6JERLL5373QGC6ZTA5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSWT5Q#discussion_r317345227">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW7YDO7OCGKZMY7LG3QGC6ZTANCNFSM4IPCU6SA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUV7CRRZ2W6VKWUYWLQGC6ZTA5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSWT5Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3134?email_source=notifications\u0026email_token=AJFFTNTU5X7IY6JERLL5373QGC6ZTA5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSWT5Q#discussion_r317345227",
"url": "https://github.com/bisq-network/bisq/pull/3134?email_source=notifications\u0026email_token=AJFFTNTU5X7IY6JERLL5373QGC6ZTA5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSWT5Q#discussion_r317345227",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>