<p><b>@ghubstan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3134#discussion_r317364107">desktop/src/test/java/bisq/desktop/util/validation/PhoneNumberValidatorTest.java</a>:</p>
<pre style='color:#555'>> +import static org.junit.Assert.assertTrue;
+
+public class PhoneNumberValidatorTest {
+ private PhoneNumberValidator validator;
+ private ValidationResult validationResult;
+
+ @Before
+ public void setup() {
+ Res.setup();
+ }
+
+ @Test
+ public void testNoInput() {
+ validator = new PhoneNumberValidator("AT");
+ validationResult = validator.validate("");
+ assertFalse("'' should not be a valid number in AT", validationResult.isValid);
</pre>
<p>I didn't create a custom assertion; I think test names and framework's existing assertions are sufficient.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3134?email_source=notifications&email_token=AJFFTNXR2ZTGJICHSURNF23QGFEP5A5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCS4JNY#discussion_r317364107">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQRH7QNAQDENE7FQ6TQGFEP5ANCNFSM4IPCU6SA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNXTX7ZJ3AMIBHRJFHLQGFEP5A5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCS4JNY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3134?email_source=notifications\u0026email_token=AJFFTNXR2ZTGJICHSURNF23QGFEP5A5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCS4JNY#discussion_r317364107",
"url": "https://github.com/bisq-network/bisq/pull/3134?email_source=notifications\u0026email_token=AJFFTNXR2ZTGJICHSURNF23QGFEP5A5CNFSM4IPCU6SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCS4JNY#discussion_r317364107",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>