<p><b>@ManfredKarrer</b> requested changes on this pull request.</p>

<p>NACK<br>
Trades are not orders and we intentionally do not use the domain language from centralized exchanged where orders get executed by a matching engine. Bisq does not work like that. Also what you edited is not the app code but a demo class as the name suggests.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3136?email_source=notifications&email_token=AJFFTNUZWD3BP7MYREG67KDQGJN2PA5CNFSM4IPHNSW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCTDVMY#pullrequestreview-279329459">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTFMZELJMGKWOC5AKTQGJN2PANCNFSM4IPHNSWQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNS7WEICGXQBGXWDJOLQGJN2PA5CNFSM4IPHNSW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCTDVMY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3136?email_source=notifications\u0026email_token=AJFFTNUZWD3BP7MYREG67KDQGJN2PA5CNFSM4IPHNSW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCTDVMY#pullrequestreview-279329459",
"url": "https://github.com/bisq-network/bisq/pull/3136?email_source=notifications\u0026email_token=AJFFTNUZWD3BP7MYREG67KDQGJN2PA5CNFSM4IPHNSW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCTDVMY#pullrequestreview-279329459",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>