<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a> I am just a spectator who joined the project recently (not involved in this PR). The way I see it is that Bisq is very short on experienced reviewers and technical project management.</p>
<p>For that reason it often requires some pushing and management by the PR <strong>author</strong> to get the changes merged in.</p>
<p>In any case, you definitely should be credited for your hard work on this regardless of who does the "final push".</p>
</blockquote>
<p>OK fair enough, as I said I'm happy that this is moving forward - but I still think it would have been much nicer if <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=232186" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a> added a couple of lines of comment which I would have turned around in a day.  That way, the contributor process would have been closely followed - in this scenario how could I possibly sign my patch (in accordance with the C4 process), it just doesn't feel right.</p>
<p>I don't mean to make a fuss of this and don't want to waste any more developer time - it's just that if a contributor did this to another contributor's patch in, say, the Decred project to which I contribute a lot, he/she would have been frowned upon to say the least.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3152?email_source=notifications&email_token=AJFFTNVERGV26MYF6IORRG3QG2ACTA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LG4QI#issuecomment-525758017">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNT6ZHAWV7YRO4D4IQTQG2ACTANCNFSM4IQMPLSA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNRGNCUNBUUWYFJSYVTQG2ACTA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LG4QI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNVERGV26MYF6IORRG3QG2ACTA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LG4QI#issuecomment-525758017",
"url": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNVERGV26MYF6IORRG3QG2ACTA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LG4QI#issuecomment-525758017",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>