<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - Please have a look at my comment on the data type of the UI theme property. I'll have a look at the css color codes next.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3152#discussion_r318607900">common/src/main/proto/pb.proto</a>:</p>
<pre style='color:#555'>> @@ -1378,6 +1378,7 @@ message PreferencesPayload {
     int32 ignore_dust_threshold = 51;
     double buyer_security_deposit_as_percent_for_crypto = 52;
     int32 block_notify_port = 53;
+    bool use_dark_mode = 54;
</pre>
<p>I think it would be better to not use a boolean in case we'll add more color variations in the future (see <a href="https://github.com/bisq-network/bisq/pull/2414/files#diff-c8de125bfd3c56b7fa8f2bca445dd516">https://github.com/bisq-network/bisq/pull/2414/files#diff-c8de125bfd3c56b7fa8f2bca445dd516</a>)</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3152#discussion_r318609142">core/src/main/java/bisq/core/locale/GlobalSettings.java</a>:</p>
<pre style='color:#555'>> @@ -47,6 +48,10 @@ public static void setUseAnimations(boolean useAnimations) {
         GlobalSettings.useAnimations = useAnimations;
     }
 
+    public static void setUseDarkMode(boolean useDarkMode) {
+        GlobalSettings.useDarkMode = useDarkMode;
</pre>
<p>I don't think we need to store it in the GlobalSettings</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3152#discussion_r318609421">core/src/main/java/bisq/core/user/Preferences.java</a>:</p>
<pre style='color:#555'>> @@ -122,6 +122,8 @@
     @Getter
     private final BooleanProperty useAnimationsProperty = new SimpleBooleanProperty(prefPayload.isUseAnimations());
     @Getter
+    private final BooleanProperty useDarkModeProperty = new SimpleBooleanProperty(prefPayload.isUseDarkMode());
</pre>
<p>See my comment on the the data type of the ui theme above.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3152?email_source=notifications&email_token=AJFFTNR7JXM4STGDQRZEUP3QG2DERA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC62QTI#pullrequestreview-280864845">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRL7GYT4QNRBLEFICTQG2DERANCNFSM4IQMPLSA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVN4EFWND6G7M2LJLLQG2DERA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC62QTI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNR7JXM4STGDQRZEUP3QG2DERA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC62QTI#pullrequestreview-280864845",
"url": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNR7JXM4STGDQRZEUP3QG2DERA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC62QTI#pullrequestreview-280864845",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>