<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a> I take the blame on having this PR around for such a long time. But that is not for no reason. As we had and partly still have quite limited dev resources to review existing PRs I just didn't have the time back then to look and finish off properly the existing PR. As far as I still remember what was left to ACK it were:</p>
<ul>
<li>exiting style issues in the light mode</li>
<li>build setup didn't work for me out-of-the-box on Intellij</li>
</ul>
<p>The big difference to this PR is, that yours contains also css clean-up and modularization of the existing CSS codebase, which was a wish from my side, as the current css was getting harder and harder to maintain.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=232186" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a> Regarding the compass CSS dependency, as it only runs on compile time I don't think it is a big security risk as any code changes outside of the CSS file would pop up in the commit anyways.</p>
<p>Not to consume more time of everyone I see following solution. Using this PR and incorporate everything which is missing from <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a>'s PR (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=232186" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a> I'll mention the required changes in the review) or breaking up <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a>'s PR in one with new color schemes (adding the css fixes from <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=232186" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a>) and another one containing the css code modularization part until the development build works and a consensus is found there regarding the additional dependency (there are obviously different positions existing in the contributor base). I'm fine with either solution - I just want to get things done and it would be great to have the dark style option integrated in Bisq.</p>
<p>What do you guys think?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3152?email_source=notifications&email_token=AJFFTNU6OV6FR2J3SWOAR4DQG2BLLA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LIBGI#issuecomment-525762713">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVJGU3MBIPWLR2SDM3QG2BLLANCNFSM4IQMPLSA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNV5ZV2J7EYZ5AVFFPTQG2BLLA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LIBGI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNU6OV6FR2J3SWOAR4DQG2BLLA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LIBGI#issuecomment-525762713",
"url": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNU6OV6FR2J3SWOAR4DQG2BLLA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LIBGI#issuecomment-525762713",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>