<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a> I take the blame on having this PR around for such a long time. But that is not for no reason. As we had and partly still have quite limited dev resources to review existing PRs I just didn't have the time back then to look and finish off properly the existing PR.</p>
</blockquote>
<p>I meant to say I know there were good reasons this PR wasn't prioritized over the DAO work going on at the time, apologies for my lousy double negative wording :)</p>
<blockquote>
<p>Not to consume more time of everyone I see following solution. Using this PR and incorporate everything which is missing from <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a>'s PR (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=232186" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a> I'll mention the required changes in the review) or breaking up <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a>'s PR in one with new color schemes (adding the css fixes from <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=232186" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a>) and another one containing the css code modularization part until the development build works and a consensus is found there regarding the additional dependency (there are obviously different positions existing in the contributor base). I'm fine with either solution - I just want to get things done and it would be great to have the dark style option integrated in Bisq.</p>
<p>What do you guys think?</p>
</blockquote>
<p>I'm happy with this suggestion.  The only thing is, the dark color scheme in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409488415" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2414" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2414/hovercard" href="https://github.com/bisq-network/bisq/pull/2414">#2414</a> is dependent on the modularized CSS, it would be very time consuming to extract the colors into <code>style.css</code> in its current form.</p>
<p>I'm looking into how to best get the color scheme fixes from <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="486022018" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3152" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3152/hovercard" href="https://github.com/bisq-network/bisq/pull/3152">#3152</a> into <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409488415" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2414" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2414/hovercard" href="https://github.com/bisq-network/bisq/pull/2414">#2414</a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3152?email_source=notifications&email_token=AJFFTNSBD4UP4FPD3OWQGGLQG2JEFA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LPFTA#issuecomment-525791948">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVGPW27S5LBUDQKFEDQG2JEFANCNFSM4IQMPLSA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNQLCWJEZLEH3YQ5KODQG2JEFA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LPFTA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNSBD4UP4FPD3OWQGGLQG2JEFA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LPFTA#issuecomment-525791948",
"url": "https://github.com/bisq-network/bisq/pull/3152?email_source=notifications\u0026email_token=AJFFTNSBD4UP4FPD3OWQGGLQG2JEFA5CNFSM4IQMPLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LPFTA#issuecomment-525791948",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>