<p>Sorry to bring another issue to the mix and be pain in the ass again :(</p>
<p>The authorization based on a fixed token is not secure against replay attacks, regardless of the underlying transfer protocol. Unfortunately, security against replay attacks requires signing individual requests, which is more complex.</p>
<p>My proposal is to remove authentication and authorization altogether.</p>
<p>This way we make it clear that API service is only supposed to be used locally. Which is perfectly fine for the initial version!</p>
<p>Also, that would significantly reduce the diff to review, as large part seems to be authentication and authorization related.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3001?email_source=notifications&email_token=AJFFTNWCXED4ZPXEIZZVD43QG3SPFA5CNFSM4IGTEHD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPJQI#issuecomment-525923521">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUXP2GXHGNK4X5CWNTQG3SPFANCNFSM4IGTEHDQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNSDF2FZQSMTHZ4SSGLQG3SPFA5CNFSM4IGTEHD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPJQI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3001?email_source=notifications\u0026email_token=AJFFTNWCXED4ZPXEIZZVD43QG3SPFA5CNFSM4IGTEHD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPJQI#issuecomment-525923521",
"url": "https://github.com/bisq-network/bisq/pull/3001?email_source=notifications\u0026email_token=AJFFTNWCXED4ZPXEIZZVD43QG3SPFA5CNFSM4IGTEHD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPJQI#issuecomment-525923521",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>