<p>Based on PR <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="452748439" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2871" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2871/hovercard" href="https://github.com/bisq-network/bisq/pull/2871">#2871</a> from <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=23560607" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a>.</p>
<p>I share the PR so that others can add optimisations for design and wording.</p>
<p>Open questions:</p>
<ul>
<li>Do we need a flag in the settings to allow the user to not receive chat messages? Would require that the peer gets that information as well which is a bit of an effort. Maybe we can keep that for a later version if needed at all.</li>
<li>Do we need a popup or "news" badge to make sure users will find the new feature? I guess it is obvious enough, specially if you get a message.</li>
<li>Do we want a badge icon showing new messages if the selected screen is not pending trades?</li>
<li>Do we want to send mobile notifications?</li>
</ul>
<p>I think all the above is not needed, at least not for a first release. But some UI beautification (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a>) and better wording (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=735155" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/m52go">@m52go</a>) would be nice...</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/54558767/63982606-6301b300-cac3-11e9-8ebd-1c8c6c131e5c.png"><img width="1423" alt="Screen Shot 2019-08-30 at 01 13 20" src="https://user-images.githubusercontent.com/54558767/63982606-6301b300-cac3-11e9-8ebd-1c8c6c131e5c.png" style="max-width:100%;"></a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/3165'>https://github.com/bisq-network/bisq/pull/3165</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Refactor Chat out of TraderDisputeView</li>
<li>Send acks when capability found</li>
<li>Separate most of Chat and arbitration</li>
<li>Move close ticket button creation to arbitration</li>
<li>Handle Chat message subscription inside Chat</li>
<li>Add ChatManager</li>
<li>Add trader chat</li>
<li>Make attachments optional</li>
<li>Test trade chat UI</li>
<li>Add comments on BSQ trade fee calculation</li>
<li>Change message box aid</li>
<li>Add basic chat UI</li>
<li>Merge branch 'master_upstream' into sq-add-trader-chat</li>
<li>Fix merge issues</li>
<li>Update string</li>
<li>Add comments, cleanup, fix wrong param name</li>
<li>Show chat in popup instead of tab (WIP)</li>
<li>Add close handler to popup</li>
<li>Merge branch 'master_upstream' into sq-add-trader-chat</li>
<li>Apply changes from master</li>
<li>Add missing allServicesInitialized check</li>
<li>Add wasDisplayed field to chatMsg</li>
<li>Add onAllServicesInitialized call, rename method</li>
<li>Add missing setWasDisplayed</li>
<li>Add badge for num new chat msg</li>
<li>Fix wrong pubkey</li>
<li>Add chat rules system msg; cleanups</li>
<li>Handle nullables</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-0">common/src/main/java/bisq/common/storage/FileManager.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-1">common/src/main/proto/pb.proto</a>
(7)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-2">core/src/main/java/bisq/core/arbitration/DisputeChatSession.java</a>
(177)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-3">core/src/main/java/bisq/core/arbitration/DisputeManager.java</a>
(285)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-4">core/src/main/java/bisq/core/arbitration/messages/DisputeCommunicationMessage.java</a>
(72)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-5">core/src/main/java/bisq/core/chat/ChatManager.java</a>
(219)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-6">core/src/main/java/bisq/core/chat/ChatSession.java</a>
(66)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-7">core/src/main/java/bisq/core/dao/governance/param/Param.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-8">core/src/main/java/bisq/core/trade/TradableList.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-9">core/src/main/java/bisq/core/trade/Trade.java</a>
(26)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-10">core/src/main/java/bisq/core/trade/TradeChatSession.java</a>
(176)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-11">core/src/main/java/bisq/core/trade/TradeManager.java</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-12">core/src/main/java/bisq/core/util/CoinUtil.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-13">core/src/main/resources/i18n/displayStrings.properties</a>
(14)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-14">desktop/src/main/java/bisq/desktop/main/Chat/Chat.java</a>
(765)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-15">desktop/src/main/java/bisq/desktop/main/disputes/trader/TraderDisputeView.java</a>
(619)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-16">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/BuyerSubView.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-17">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.fxml</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-18">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java</a>
(202)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3165/files#diff-19">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/TradeSubView.java</a>
(10)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/3165.patch'>https://github.com/bisq-network/bisq/pull/3165.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/3165.diff'>https://github.com/bisq-network/bisq/pull/3165.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3165?email_source=notifications&email_token=AJFFTNVNADTI4KHDUHITYR3QHBKV5A5CNFSM4ISHVMHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIKKVUQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRKR5ILLOFKYQAN5A3QHBKV5ANCNFSM4ISHVMHA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUTTJPEYY2D4POWJPDQHBKV5A5CNFSM4ISHVMHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIKKVUQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3165?email_source=notifications\u0026email_token=AJFFTNVNADTI4KHDUHITYR3QHBKV5A5CNFSM4ISHVMHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIKKVUQ",
"url": "https://github.com/bisq-network/bisq/pull/3165?email_source=notifications\u0026email_token=AJFFTNVNADTI4KHDUHITYR3QHBKV5A5CNFSM4ISHVMHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIKKVUQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>