<p><b>@sqrrm</b> commented on this pull request.</p>
<p>Some minor comments</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3169#discussion_r319722905">core/src/main/java/bisq/core/dispute/DisputeResolverService.java</a>:</p>
<pre style='color:#555'>> + log.warn("bannedDisputeResolvers=" + bannedDisputeResolvers);
+ Set<T> disputeResolverSet = getCollect(bannedDisputeResolvers);
+
+ Map<NodeAddress, T> map = new HashMap<>();
+ for (T disputeResolver : disputeResolverSet) {
+ NodeAddress disputeResolverNodeAddress = disputeResolver.getNodeAddress();
+ if (!map.containsKey(disputeResolverNodeAddress))
+ map.put(disputeResolverNodeAddress, disputeResolver);
+ else
+ log.warn("disputeResolverAddress already exist in disputeResolver map. Seems an disputeResolver object is already registered with the same address.");
+ }
+ return map;
+ }
+
+ @NotNull
+ protected abstract Set<T> getCollect(List<String> bannedDisputeResolvers);
</pre>
<p><code>getCollect()</code> is not a great name, <code>getSet()</code> might be better</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3169#discussion_r319723168">desktop/src/main/java/bisq/desktop/main/account/register/DisputeResolverRegistrationView.java</a>:</p>
<pre style='color:#555'>> + registerButton.disableProperty().bind(model.registrationEditDisabled);
+ registerButton.setOnAction(e -> onRegister());
+
+ Button revokeButton = buttonButtonTuple2.second;
+ revokeButton.setDefaultButton(false);
+ revokeButton.disableProperty().bind(model.revokeButtonDisabled);
+ revokeButton.setOnAction(e -> onRevoke());
+
+ final TitledGroupBg titledGroupBg = addTitledGroupBg(gridPane, ++gridRow, 2,
+ Res.get("shared.information"), Layout.GROUP_DISTANCE);
+
+ titledGroupBg.getStyleClass().add("last");
+
+ Label infoLabel = addMultilineLabel(gridPane, gridRow);
+ GridPane.setMargin(infoLabel, new Insets(Layout.TWICE_FIRST_ROW_AND_GROUP_DISTANCE, 0, 0, 0));
+ infoLabel.setText(Res.get("account.arbitratorRegistration.info.msg"));
</pre>
<p>This info text is not generic enough for both mediator and arbitrator</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3169#discussion_r319723233">core/src/main/java/bisq/core/dispute/DisputeResolverManager.java</a>:</p>
<pre style='color:#555'>> }
///////////////////////////////////////////////////////////////////////////////////////////
// Abstract methods
///////////////////////////////////////////////////////////////////////////////////////////
+ protected abstract List<String> getPubLeyList();
</pre>
<p>Should be getPub<strong>K</strong>eyList</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3169?email_source=notifications&email_token=AJFFTNQF47J53YRTL4PLIC3QHJTAXA5CNFSM4ISQRRTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDJ2D4Y#pullrequestreview-282305011">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQD3QYS4JOQT6O6H33QHJTAXANCNFSM4ISQRRTA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNWS6ZDKQGRS5NTEGALQHJTAXA5CNFSM4ISQRRTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDJ2D4Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3169?email_source=notifications\u0026email_token=AJFFTNQF47J53YRTL4PLIC3QHJTAXA5CNFSM4ISQRRTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDJ2D4Y#pullrequestreview-282305011",
"url": "https://github.com/bisq-network/bisq/pull/3169?email_source=notifications\u0026email_token=AJFFTNQF47J53YRTL4PLIC3QHJTAXA5CNFSM4ISQRRTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDJ2D4Y#pullrequestreview-282305011",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>