<p>This removes <code>org.bouncycastle:bcprov</code> from <strong>direct</strong> dependencies.</p>
<p>We still depend on this jar <strong>indirectly</strong> via <code>bouncycastle:bcpg</code>, which is used for PGP signature verification of Bisq Desktop updates.</p>
<p>This gets us closer to prospect of removing Bounce Castle dependency entirely in the future.</p>
<p>Rationale for this direction:</p>
<ul>
<li>We are really only using Bouncy Castle for PGP sig verification</li>
<li>Java's builtin cryptography got vastly better since 2000; no more key length restrictions</li>
<li>We should prefer boring and proven cryptography anyway</li>
<li>Australian projects should be considered compromised and Bouncy Castle is managed by Australian non-profit organization</li>
<li>Bouncy Castle is a heavy dependency totaling 3.6MB</li>
</ul>
<p>In the process:</p>
<ul>
<li>Ergo coin got removed</li>
<li>BC Base64 got replaced with Java's builtin version (which is much faster BTW)</li>
<li>BC Hex got replaced with Guava's version</li>
</ul>
<p>Note to reviewers: individual commits are easier to review than full diff. They also provide more details.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3195'>https://github.com/bisq-network/bisq/pull/3195</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Replace bouncycastle Hex with guava Hex</li>
  <li>Replace bouncycastle Base64 with java builtin Base64</li>
  <li>Remove Ergo coin as prep to remove Bouncy Castle</li>
  <li>Remove bouncycastle:bcprov from *direct* dependencies</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-0">assets/src/main/java/bisq/asset/coins/Ergo.java</a>
    (66)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-1">assets/src/main/resources/META-INF/services/bisq.asset.Asset</a>
    (1)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-2">assets/src/test/java/bisq/asset/coins/ErgoTest.java</a>
    (48)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-3">build.gradle</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-4">common/src/main/java/bisq/common/crypto/CryptoUtils.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-5">common/src/main/java/bisq/common/crypto/Encryption.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-6">common/src/main/java/bisq/common/crypto/PGP.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-7">common/src/main/java/bisq/common/crypto/Sig.java</a>
    (6)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-8">common/src/main/java/bisq/common/util/Base64.java</a>
    (33)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-9">common/src/main/java/bisq/common/util/Hex.java</a>
    (31)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-10">core/src/test/java/bisq/core/crypto/EncryptionTest.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-11">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3195/files#diff-12">pricenode/src/main/java/bisq/price/spot/providers/BitcoinAverage.java</a>
    (5)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3195.patch'>https://github.com/bisq-network/bisq/pull/3195.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3195.diff'>https://github.com/bisq-network/bisq/pull/3195.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3195?email_source=notifications&email_token=AJFFTNQ4XRZLRDO47ICNIH3QHZRPFA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI7SM6A">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXCO5IFDTLW4SAQNZLQHZRPFANCNFSM4ITGMJ3Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUOI5DMH6PFAENH75DQHZRPFA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI7SM6A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3195?email_source=notifications\u0026email_token=AJFFTNQ4XRZLRDO47ICNIH3QHZRPFA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI7SM6A",
"url": "https://github.com/bisq-network/bisq/pull/3195?email_source=notifications\u0026email_token=AJFFTNQ4XRZLRDO47ICNIH3QHZRPFA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI7SM6A",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>