<p><b>@battleofwizards</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3195#discussion_r320304816">common/src/main/java/bisq/common/util/Hex.java</a>:</p>
<pre style='color:#555'>> + */
+
+package bisq.common.util;
+
+import com.google.common.io.BaseEncoding;
+
+public class Hex {
+
+    public static byte[] decode(String hex) {
+        return BaseEncoding.base16().lowerCase().decode(hex.toLowerCase());
+    }
+
+    public static String encode(byte[] bytes) {
+        return BaseEncoding.base16().lowerCase().encode(bytes);
+    }
+}
</pre>
<p>Yes, I am aware of Utilities and BitcoinJ versions of Hex being used in the code. It did cross my mind to standardize this but I decided it is too broad for this PR.</p>
<p>In this PR I focused on minimizing the diff and ensuring backwards compatibility. We need exactly the same behavior from replacements as original Bounce Castle versions.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3195?email_source=notifications&email_token=AJFFTNTKUZFMHW6J5FKHDJ3QHZYKHA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDPNBBQ#discussion_r320304816">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVZZZGV6WYJNO7NG5DQHZYKHANCNFSM4ITGMJ3Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNQRTFSYF5UGP2KJK7DQHZYKHA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDPNBBQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3195?email_source=notifications\u0026email_token=AJFFTNTKUZFMHW6J5FKHDJ3QHZYKHA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDPNBBQ#discussion_r320304816",
"url": "https://github.com/bisq-network/bisq/pull/3195?email_source=notifications\u0026email_token=AJFFTNTKUZFMHW6J5FKHDJ3QHZYKHA5CNFSM4ITGMJ32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDPNBBQ#discussion_r320304816",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>