<p><b>@m52go</b> commented on this pull request.</p>
<p>Looks good to me. Just 1 missed translation, which I noted with a suggestion.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/221#discussion_r320854053">_data/fr.yml</a>:</p>
<pre style='color:#555'>> - <p class='stat-label'>Total des transactions</p> <p class='stat-figure'>32,318</p> <p class='stat-note'>Pour Juin 2019</p>
- pDailyAverage: >
- <p class='stat-label'>Moyenne journalière des transactions</p> <p class='stat-figure'>94</p> <p class='stat-note'>En Juin 2019</p>
- pSoftwareDownloads: >
- <p class='stat-label'>Téléchargements du logiciel</p> <p class='stat-figure'>13,723</p> <p class='stat-note'>For v1.1.2 (approximation)</p>
- pGithubContributors: >
- <p class='stat-label'>Contributeurs GitHub </p> <p class='stat-figure'>172</p> <p class='stat-note'>En Juin 2019</p>
- pTwitterFollowers: >
- <p class='stat-label'>Followers sur Twitter </p> <p class='stat-figure'>17,588</p> <p class='stat-note'>En Juin 2019</p>
- pSlackUsers: >
- <p class='stat-label'> Utilisateurs Slack</p> <p class='stat-figure'>1,183</p> <p class='stat-note'>En Juin 2019</p>
+ pTotalTrades: Total des transactions
+ pTotalDate: Au cours du mois dernier
+ pDailyAverageTrade: Moyenne journalière des transactions
+ pSoftwareDownloads: Téléchargements du logiciel
+ pSoftwareDownloadsVersion: For v1.1.2 (approximation)
</pre>
<p>Still English. This looks like a decent translation from my time taking French.</p>
⬇️ Suggested change
<pre style="color: #555">- pSoftwareDownloadsVersion: For v1.1.2 (approximation)
+ pSoftwareDownloadsVersion: Pour v1.1.2 (environ)
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-website/pull/221?email_source=notifications&email_token=AJFFTNQYJJMJHAQLV5IYTFLQH7OT7A5CNFSM4IQCDTWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDUYMNA#pullrequestreview-283739700">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQERYYHECJKC6L7ED3QH7OT7ANCNFSM4IQCDTWA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNRHIMBQIRQRLEWGEFLQH7OT7A5CNFSM4IQCDTWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDUYMNA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-website/pull/221?email_source=notifications\u0026email_token=AJFFTNQYJJMJHAQLV5IYTFLQH7OT7A5CNFSM4IQCDTWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDUYMNA#pullrequestreview-283739700",
"url": "https://github.com/bisq-network/bisq-website/pull/221?email_source=notifications\u0026email_token=AJFFTNQYJJMJHAQLV5IYTFLQH7OT7A5CNFSM4IQCDTWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDUYMNA#pullrequestreview-283739700",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>