<p><b>@chimp1984</b> commented on this pull request.</p>

<p>Would need a bit more time for testing PR... On first look it looks ok.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3202#discussion_r320882123">p2p/src/main/java/bisq/network/p2p/P2PService.java</a>:</p>
<pre style='color:#555'>> @@ -337,11 +340,13 @@ public void onPreliminaryDataReceived() {
 
     @Override
     public void onUpdatedDataReceived() {
-        isBootstrapped = true;
-        maybeProcessAllMailboxEntries();
-        p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
-        if(!isBootstrapped)
-            p2PDataStorage.onBootstrapComplete();
+        if (!isBootstrapped() || Capabilities.app.containsAll(Capability.SEED_NODE)) {
+            isBootstrapped = true;
+            maybeProcessAllMailboxEntries();
+            p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
+            if (!isBootstrapped)
+                p2PDataStorage.onBootstrapComplete();
+        }
</pre>
<p>In your new code it is not executed is isBootStapped=true and not a seed node. Without having looked to a wider context that seems wrong or at lease a behaviour change.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3202#discussion_r320883329">p2p/src/main/java/bisq/network/p2p/P2PService.java</a>:</p>
<pre style='color:#555'>> @@ -337,11 +340,13 @@ public void onPreliminaryDataReceived() {
 
     @Override
     public void onUpdatedDataReceived() {
-        isBootstrapped = true;
-        maybeProcessAllMailboxEntries();
-        p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
-        if(!isBootstrapped)
-            p2PDataStorage.onBootstrapComplete();
+        if (!isBootstrapped() || Capabilities.app.containsAll(Capability.SEED_NODE)) {
+            isBootstrapped = true;
+            maybeProcessAllMailboxEntries();
+            p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
+            if (!isBootstrapped)
+                p2PDataStorage.onBootstrapComplete();
+        }
</pre>
<p>Ah ignore previous comment... See in the first commit the original code...</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3202#discussion_r320883654">p2p/src/main/java/bisq/network/p2p/P2PService.java</a>:</p>
<pre style='color:#555'>> @@ -337,11 +340,13 @@ public void onPreliminaryDataReceived() {
 
     @Override
     public void onUpdatedDataReceived() {
-        isBootstrapped = true;
-        maybeProcessAllMailboxEntries();
-        p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
-        if(!isBootstrapped)
-            p2PDataStorage.onBootstrapComplete();
+        if (!isBootstrapped() || Capabilities.app.containsAll(Capability.SEED_NODE)) {
+            isBootstrapped = true;
+            maybeProcessAllMailboxEntries();
+            p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
+            if (!isBootstrapped)
+                p2PDataStorage.onBootstrapComplete();
+        }
</pre>
<p>Maybe worth to squash all commits, makes review easier</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3202?email_source=notifications&email_token=AJFFTNSOKTTUBJ4IJMUPBELQH7WPZA5CNFSM4ITUM76KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDVBE4Y#pullrequestreview-283775603">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWLUQYBC2ZB44MU3F3QH7WPZANCNFSM4ITUM76A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNRQVDUWW2AUH5LKRMTQH7WPZA5CNFSM4ITUM76KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDVBE4Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3202?email_source=notifications\u0026email_token=AJFFTNSOKTTUBJ4IJMUPBELQH7WPZA5CNFSM4ITUM76KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDVBE4Y#pullrequestreview-283775603",
"url": "https://github.com/bisq-network/bisq/pull/3202?email_source=notifications\u0026email_token=AJFFTNSOKTTUBJ4IJMUPBELQH7WPZA5CNFSM4ITUM76KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDVBE4Y#pullrequestreview-283775603",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>